External schemes do not fire a sheet on ITP

duckduckgo · Feb 16, 2024 · 4651afe · 4651afe
1 parent 72fdf7f
commit 4651afe
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/DuckDuckGo/Subscription/ViewModel/SubscriptionITPViewModel.swift b/DuckDuckGo/Subscription/ViewModel/SubscriptionITPViewModel.swift
@@ -36,6 +36,7 @@ final class SubscriptionITPViewModel: ObservableObject {
         static let navigationBarHideThreshold = 60.0
         static let downloadableContent = ["application/pdf"]
         static let blankURL = "about:blank"
+        static let externalSchemes =  ["tel", "sms", "facetime"]
     }
 
     // State variables
@@ -123,8 +124,9 @@ final class SubscriptionITPViewModel: ObservableObject {
                     self.isDownloadableContent = false
                     self.currentURL = url
                 } else {
-                    // Fire up navigation in a separate View
-                    if url.absoluteString != Constants.blankURL {
+                    // Fire up navigation in a separate View (if a valid link)
+                    if url.absoluteString != Constants.blankURL &&
+                       !Constants.externalSchemes.contains(url.scheme ?? "") {
                         self.shouldNavigateToExternalURL = url
                     }
                 }