Fix an issue that would create an extra tab when leaving a malicious …

…site and only one tab is in the stack
duckduckgo · Jan 30, 2025 · 4dc692e · 4dc692e
1 parent 1d8ac73
commit 4dc692e
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/DuckDuckGo/TabManager.swift b/DuckDuckGo/TabManager.swift
@@ -308,8 +308,13 @@ class TabManager {
     }
 
     func replaceTab(at index: Int, withNewTab newTab: Tab) {
-        model.remove(at: index)
-        model.insert(tab: newTab, at: index)
+        // Removing a Tab automatically inserts a new one if tabs are empty. Hence add a new one only if needed
+        if model.tabs.count == 1 {
+            model.remove(at: index)
+        } else {
+            model.remove(at: index)
+            model.insert(tab: newTab, at: index)
+        }
         save()
     }