Skip to content

Commit

Permalink
Update Bookmarks UI and extract Bookmarks database (#1404)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/72649045549333/1202533376181935/f
Tech Design URL:
CC:

Description:

Steps to test this PR:

Test Migration. Using a build from develop create bookmarks, favorites, folders. Install new version and check they are migrated successfully (favorite merged with bookmark if same url, old database cleaned etc).
Test Clean install. Using a clean build from develop, ensure app starts and you can create bookmarks, favorites, folders, etc.
Check that changes are preserved across app restarts.
Check dependency chain and how Main view is now instantiated. Validate app start/restart state and lock/auto clear.
Check add/edit bookmark / favorite from browsing menu and menu updates to show correct state on change.
Check bookmark manager view shows bookmarks and folder navigation works.
Check bookmark manager view allows editing of bookmarks and folders.
Use swipe actions in bookmark manager view to set as favorite and delete.
Search functionality in bookmark manager shows expected bookmarks and swipe to favorite/delete works. Search updates when DB state changes.
When using address bar bookmarks top 2 matching bookmarks appear in the suggestions, and what you see matches DB latest state.
Favorites can be re-ordered on the favorites tab.
Switching between bookmarks and favorites updates the UI correctly.
Add all bookmarks from from tab switcher.
Favicons are saved as expected for bookmarks when they are added
Favorites are show in overlay (not re-orderable or editable)
Favorites show on home screen and are re-orderable
Favorites show edit / remove menu when long pressed
Bookmarks import & export works as expected.
  • Loading branch information
brindy authored Dec 15, 2022
1 parent 300d338 commit 77dafc4
Show file tree
Hide file tree
Showing 173 changed files with 109,590 additions and 5,317 deletions.
68 changes: 0 additions & 68 deletions Core/BookmarkOrFolder.swift

This file was deleted.

36 changes: 0 additions & 36 deletions Core/BookmarkStore.swift

This file was deleted.

96 changes: 0 additions & 96 deletions Core/BookmarkUserDefaults.swift

This file was deleted.

Loading

0 comments on commit 77dafc4

Please sign in to comment.