Skip to content

Commit

Permalink
Add app-configuration App Group (#3295)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/72649045549333/1208165258583208/f
Tech Design URL:
CC:

**Description**:

This PR adds the `app-configuration` App Group.

<!--
If at any point it isn't actively being worked on/ready for
review/otherwise moving forward strongly consider closing it (or not
opening it in the first place). If you decide not to close it, use Draft
PR while work is still in progress or use `DO NOT MERGE` label to
clarify the PRs state and comment with more information.
-->

**Steps to test this PR**:
1. You will likely need to refresh your provisioning profiles locally
first
2. Next, make sure that the app builds and runs as expected
3. Now we need to test that the app group is working, you can use the
following code to do so:

```
let fileURL = FileManager.default.containerURL(forSecurityApplicationGroupIdentifier: "\(Global.groupIdPrefix).app-configuration")!.appendingPathComponent("example.txt")
do {
    let data = "hello, world".data(using: .utf8)!
    try data.write(to: fileURL)
    print("File written to: \(fileURL.path)")
} catch {
    print("Failed to write to file: \(error.localizedDescription)")
}
```

<!--
Before submitting a PR, please ensure you have tested the combinations
you expect the reviewer to test, then delete configurations you *know*
do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
-->

**Definition of Done (Internal Only)**:

* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

**Copy Testing**:

* [ ] Use of correct apostrophes in new copy, ie `’` rather than `'`

**Orientation Testing**:

* [ ] Portrait
* [ ] Landscape

**Device Testing**:

* [ ] iPhone SE (1st Gen)
* [ ] iPhone 8
* [ ] iPhone X
* [ ] iPhone 14 Pro
* [ ] iPad

**OS Testing**:

* [ ] iOS 15
* [ ] iOS 16
* [ ] iOS 17

**Theme Testing**:

* [ ] Light theme
* [ ] Dark theme

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
  • Loading branch information
samsymons authored Aug 30, 2024
1 parent 137dd1e commit 79ea8b4
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
7 changes: 4 additions & 3 deletions DuckDuckGo/DuckDuckGo.entitlements
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,22 @@
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.developer.browser.app-installation</key>
<true/>
<key>com.apple.developer.networking.networkextension</key>
<array>
<string>packet-tunnel-provider</string>
</array>
<key>com.apple.developer.web-browser</key>
<true/>
<key>com.apple.developer.browser.app-installation</key>
<true/>
<key>com.apple.security.application-groups</key>
<array>
<string>$(GROUP_ID_PREFIX).bookmarks</string>
<string>$(GROUP_ID_PREFIX).contentblocker</string>
<string>$(GROUP_ID_PREFIX).statistics</string>
<string>$(GROUP_ID_PREFIX).database</string>
<string>$(GROUP_ID_PREFIX).netp</string>
<string>$(GROUP_ID_PREFIX).statistics</string>
<string>group.com.duckduckgo.app-configuration</string>
</array>
<key>keychain-access-groups</key>
<array>
Expand Down
1 change: 1 addition & 0 deletions DuckDuckGo/DuckDuckGoAlpha.entitlements
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<string>group.com.duckduckgo.alpha.database</string>
<string>group.com.duckduckgo.alpha.netp</string>
<string>group.com.duckduckgo.alpha.statistics</string>
<string>group.com.duckduckgo.alpha.app-configuration</string>
</array>
<key>keychain-access-groups</key>
<array>
Expand Down
1 change: 1 addition & 0 deletions PacketTunnelProvider/PacketTunnelProvider.entitlements
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<key>com.apple.security.application-groups</key>
<array>
<string>$(GROUP_ID_PREFIX).netp</string>
<string>group.com.duckduckgo.app-configuration</string>
</array>
<key>keychain-access-groups</key>
<array>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<key>com.apple.security.application-groups</key>
<array>
<string>group.com.duckduckgo.alpha.netp</string>
<string>group.com.duckduckgo.alpha.app-configuration</string>
</array>
<key>keychain-access-groups</key>
<array>
Expand Down

0 comments on commit 79ea8b4

Please sign in to comment.