Skip to content

Commit

Permalink
Ship review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Bunn committed Dec 4, 2024
1 parent 28f7896 commit 906775c
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
16 changes: 8 additions & 8 deletions DuckDuckGo/SettingsMainSettingsView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,6 @@ struct SettingsMainSettingsView: View {
image: Image("SettingsDataClearing"))
}

// AI Chat
if viewModel.state.aiChatEnabled {
NavigationLink(destination: SettingsAIChatView().environmentObject(viewModel)) {
SettingsCellView(label: UserText.aiChatFeatureName,
image: Image("SettingsAIChat"))
}
}

// Duck Player
// We need to hide the settings until the user is enrolled in the experiment
if viewModel.state.duckPlayerEnabled {
Expand All @@ -84,6 +76,14 @@ struct SettingsMainSettingsView: View {
image: Image("SettingsDuckPlayer"))
}
}

// AI Chat
if viewModel.state.aiChatEnabled {
NavigationLink(destination: SettingsAIChatView().environmentObject(viewModel)) {
SettingsCellView(label: UserText.aiChatFeatureName,
image: Image("SettingsAIChat"))
}
}
}

}
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo/UserText.swift
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public struct UserText {
public static let actionCopyMessage = NSLocalizedString("action.title.copy.message", value: "URL copied", comment: "Floating message indicating URL has been copied")
public static let actionShare = NSLocalizedString("action.title.share", value: "Share", comment: "Share action")
public static let actionPrint = NSLocalizedString("action.title.print", value: "Print", comment: "Print action in the menu header")
public static let actionPrintSite = NSLocalizedString("action.title.print.site", value: "Print Site", comment: "Print action in the menu list")
public static let actionPrintSite = NSLocalizedString("action.title.print.site", value: "Print", comment: "Print action in the menu list")
public static let actionOpenAIChat = NSLocalizedString("action.title.aichat", value: "Chat", comment: "Open AI Chat action in the menu list")

public static let actionOpenBookmarks = NSLocalizedString("action.title.bookmarks", value: "Bookmarks", comment: "Button: Open bookmarks list")
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo/en.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"action.title.print" = "Print";

/* Print action in the menu list */
"action.title.print.site" = "Print Site";
"action.title.print.site" = "Print";

/* Refresh action - button shown in alert */
"action.title.refresh" = "Refresh";
Expand Down

0 comments on commit 906775c

Please sign in to comment.