-
Notifications
You must be signed in to change notification settings - Fork 425
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Loading status checks…
Fix favorites grid layout issues on New Tab Page (#3568)
<!-- Note: This checklist is a reminder of our shared engineering expectations. Feel free to change it, although assigning a GitHub reviewer and the items in bold are required.⚠️ If you're an external contributor, please file an issue first before working on a PR, as we can't guarantee that we will accept your changes if they haven't been discussed ahead of time. Thanks! --> Task/Issue URL: https://app.asana.com/0/1206226850447395/1208709136086082/f Tech Design URL: CC: **Description**: Addresses feedback around updated favorites grid layout on New Tab Page. * Uses static column setup with 4 columns on iPhone and 5 on iPad when NTP customization is turned off. * Reduces the width of grid and makes it centered. * A special case handled for smaller screens so the static layout does not exceed margins. **Steps to test this PR**: For best baseline run 7.142.1 or earlier. 1. Add at least 5 favorites 2. Verify number of columns shown and their count does not change when rotated to landscape: a. 4 on iPhone b. 5 on iPad (unless in compact-sized Split View) **Definition of Done (Internal Only)**: * [x] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? **Orientation Testing**: * [x] Portrait * [x] Landscape **Device Testing**: * [x] iPhone SE (1st Gen) * [ ] iPhone 8 * [ ] iPhone X * [x] iPhone 16 Pro * [x] iPad **OS Testing**: * [x] iOS 15 * [ ] iOS 16 * [x] iOS 18 **Theme Testing**: * [x] Light theme * [x] Dark theme --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
- 7.152.0-1
- 7.152.0-0
- 7.151.0
- 7.151.0-0
- 7.150.0-1
- 7.150.0-0
- 7.149.1
- 7.149.0
- 7.149.0-3
- 7.149.0-2
- 7.149.0-1
- 7.149.0-0
- 7.148.0
- 7.148.0-3
- 7.148.0-2
- 7.148.0-1
- 7.148.0-0
- 7.147.1
- 7.147.0
- 7.147.0-6
- 7.147.0-5
- 7.147.0-4
- 7.147.0-3
- 7.147.0-2
- 7.147.0-1
- 7.147.0-0
- 7.146.2
- 7.146.1
- 7.146.0
- 7.146.0-3
- 7.146.0-2
- 7.146.0-1
- 7.146.0-0
- 7.145.1
- 7.145.0
- 7.145.0-2
Showing
6 changed files
with
63 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters