Skip to content

Commit

Permalink
Use WKHTTPCookieStoreWrapper to better control cookie store concurren…
Browse files Browse the repository at this point in the history
…cy (#3625)

Task/Issue URL:
https://app.asana.com/0/414709148257752/1208829922317861/f

**Description**:
Use WKHTTPCookieStoreWrapper to better control cookie store concurrency

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)

---------

Co-authored-by: Sam Symons <[email protected]>
  • Loading branch information
miasma13 and samsymons authored Nov 26, 2024
1 parent 9d38d01 commit eca7fdd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -11040,7 +11040,7 @@
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = "211.0.0-1";
version = "211.0.0-2";
};
};
9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/DuckDuckGo/BrowserServicesKit",
"state" : {
"revision" : "135c63a3058b975cbc2d00ce637f3b9727b717ae",
"version" : "211.0.0-1"
"revision" : "c99d4e9437ae42d89362fc9845171076d3c7cc47",
"version" : "211.0.0-2"
}
},
{
Expand Down Expand Up @@ -138,7 +138,7 @@
{
"identity" : "swift-argument-parser",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-argument-parser",
"location" : "https://github.com/apple/swift-argument-parser.git",
"state" : {
"revision" : "0fbc8848e389af3bb55c182bc19ca9d5dc2f255b",
"version" : "1.4.0"
Expand Down
4 changes: 2 additions & 2 deletions DuckDuckGo/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ import os.log
return nil
}

return WKWebsiteDataStore.current().httpCookieStore
return WKHTTPCookieStoreWrapper(store: WKWebsiteDataStore.current().httpCookieStore)
}, eventMapping: SubscriptionCookieManageEventPixelMapping())


Expand Down Expand Up @@ -629,7 +629,7 @@ import os.log
}
}

Task { @MainActor in
Task {
await subscriptionCookieManager.refreshSubscriptionCookie()
}

Expand Down

0 comments on commit eca7fdd

Please sign in to comment.