Skip to content

Commit

Permalink
Merge branch 'sam/vpn-ui-improvements' into sam/vpn-ui-improvements-2…
Browse files Browse the repository at this point in the history
…-lottie-animation

* sam/vpn-ui-improvements:
  Fix unit tests.
  rollback #URL macro (#2585)
  Release 7.112.0-2 (#2579)
  Updates BSK (#2577)
  • Loading branch information
samsymons committed Mar 14, 2024
2 parents b73a8c9 + c7fd81d commit f0898f9
Show file tree
Hide file tree
Showing 37 changed files with 135 additions and 232 deletions.
3 changes: 1 addition & 2 deletions Core/AppURLs.swift
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

import BrowserServicesKit
import Foundation
import Macros

public extension URL {

Expand Down Expand Up @@ -49,7 +48,7 @@ public extension URL {
static let exti = URL(string: "\(base)/exti/\(devMode)")!
static let feedback = URL(string: "\(base)/feedback.js?type=app-feedback")!

static let appStore = #URL("https://apps.apple.com/app/duckduckgo-privacy-browser/id663592361")
static let appStore = URL(string: "https://apps.apple.com/app/duckduckgo-privacy-browser/id663592361")!

static let mac = URL(string: "\(base)/mac")!
static let windows = URL(string: "\(base)/windows")!
Expand Down
3 changes: 1 addition & 2 deletions Core/BookmarksImporter.swift
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import Bookmarks
import Common
import Foundation
import Macros
import Persistence
import SwiftSoup

Expand Down Expand Up @@ -218,7 +217,7 @@ final public class BookmarksImporter {
static let FavoritesFolder = "DuckDuckGo Favorites"
static let BookmarksFolder = "DuckDuckGo Bookmarks"
static let bookmarkURLString = "https://duckduckgo.com"
static let bookmarkURL = #URL("https://duckduckgo.com")
static let bookmarkURL = URL(string: "https://duckduckgo.com")!
static let favoriteAttribute = "duckduckgo:favorite"
static let isFavorite = "true"
static let idAttribute = "id"
Expand Down
3 changes: 1 addition & 2 deletions Core/DataStoreWarmup.swift
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
//

import Combine
import Macros
import WebKit

/// WKWebsiteDataStore is basically non-functional until a web view has been instanciated and a page is successfully loaded.
Expand All @@ -28,7 +27,7 @@ public class DataStoreWarmup {

@MainActor
public func ensureReady() async {
await BlockingNavigationDelegate().loadInBackgroundWebView(url: #URL("about:blank"))
await BlockingNavigationDelegate().loadInBackgroundWebView(url: URL(string: "about:blank")!)
}

}
Expand Down
3 changes: 1 addition & 2 deletions Core/UserAgentManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import BrowserServicesKit
import Common
import Foundation
import Macros
import WebKit

public protocol UserAgentManager {
Expand All @@ -47,7 +46,7 @@ public class DefaultUserAgentManager: UserAgentManager {

private func prepareUserAgent() {
let webview = WKWebView()
webview.load(URLRequest.developerInitiated(#URL("about:blank")))
webview.load(URLRequest.developerInitiated(URL(string: "about:blank")!))
getDefaultAgent(webView: webview) { [weak self] agent in
// Reference webview instance to keep it in scope and allow UA to be returned
_ = webview
Expand Down
Loading

0 comments on commit f0898f9

Please sign in to comment.