-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly alpha builds #1996
Nightly alpha builds #1996
Conversation
e3db6b7
to
f335d63
Compare
6e3e87f
to
63e149d
Compare
@@ -94,3 +94,8 @@ jobs: | |||
with: | |||
report_paths: unittests.xml | |||
|
|||
deploy-alpha: | |||
name: Deploy Nightly Alpha Build | |||
uses: ./.github/workflows/alpha.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work? :) I think alpha.yml would need a workflow_call
trigger set up in order to be called from another workflow. Currently it only has workflow_dispatch
which is not quite the same (this one is used for running workflows manually).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay, good to know! Will update that.
Related: wasn’t sure how to test nightly workflows from a branch...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! (I think)
.github/workflows/alpha.yml
Outdated
INPUT_DESTINATION=${{ github.event.inputs.destination }} | ||
echo "destination=${INPUT_DESTINATION}" >> $GITHUB_OUTPUT | ||
|
||
# - name: Assert develop branch TODO: Uncomment before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be uncommented before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job @graeme! Remember to remove parts that need to be removed before merging and save your changes 😆
Task/Issue URL: https://app.asana.com/0/0/1204986042798452/f
Tech Design URL: https://app.asana.com/0/481882893211075/1204986042798431/f
CC: @loremattei @THISISDINOSAUR @ayoy
Description:
Right now, we’re concentrating most of our internal testing on the release candidates. This means that we have a lot fewer eyes on issues that might have been merged much earlier in the cycle. Furthermore, we have to rely on bespoke builds for anything that’s kept only do the Debug build config and rely on people needing to authenticate to see debug options (which means only the latest OS versions).
The ability to build alphas was already merged in #1913 but it still relied on building an distributing locally from Xcode. This PR adds:
Steps to test this PR:
Copy Testing:
’
rather than’
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template