Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly alpha builds #1996

Merged
merged 29 commits into from
Sep 20, 2023
Merged

Nightly alpha builds #1996

merged 29 commits into from
Sep 20, 2023

Conversation

graeme
Copy link
Contributor

@graeme graeme commented Sep 8, 2023

Task/Issue URL: https://app.asana.com/0/0/1204986042798452/f
Tech Design URL: https://app.asana.com/0/481882893211075/1204986042798431/f
CC: @loremattei @THISISDINOSAUR @ayoy

Description:
Right now, we’re concentrating most of our internal testing on the release candidates. This means that we have a lot fewer eyes on issues that might have been merged much earlier in the cycle. Furthermore, we have to rely on bespoke builds for anything that’s kept only do the Debug build config and rely on people needing to authenticate to see debug options (which means only the latest OS versions).

The ability to build alphas was already merged in #1913 but it still relied on building an distributing locally from Xcode. This PR adds:

  • The ability to build Alphas to a specified TestFlight group from GHA
  • Nightly Alpha build deployments

Steps to test this PR:

  1. Take a look at the most recent successful build from the added action
  2. Take a look the DuckDuckGo Alpha TestFlight on App Store Connect and check that the build number from the recent build’s logs is visible there. It’s been distributed to the "Latest Alpha Group” for testing / outside of nightly deployment purposes. Feel free to add yourself to this group and check that you see the build on TestFlight (but that’s just testing TestFlight so probably not necessary).
  3. Check that the Alpha build dSyms have been uploaded to the Asana task

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@graeme graeme force-pushed the graeme/ios-nightly-alphas branch 4 times, most recently from e3db6b7 to f335d63 Compare September 12, 2023 09:18
@graeme graeme force-pushed the graeme/ios-nightly-alphas branch from 6e3e87f to 63e149d Compare September 12, 2023 14:55
@graeme graeme changed the title ios nightly alphas Nightly alpha builds Sep 13, 2023
@graeme graeme requested review from jaceklyp and ayoy September 13, 2023 10:23
@@ -94,3 +94,8 @@ jobs:
with:
report_paths: unittests.xml

deploy-alpha:
name: Deploy Nightly Alpha Build
uses: ./.github/workflows/alpha.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? :) I think alpha.yml would need a workflow_call trigger set up in order to be called from another workflow. Currently it only has workflow_dispatch which is not quite the same (this one is used for running workflows manually).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, good to know! Will update that.

Related: wasn’t sure how to test nightly workflows from a branch...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! (I think)

.github/workflows/nightly.yml Outdated Show resolved Hide resolved
INPUT_DESTINATION=${{ github.event.inputs.destination }}
echo "destination=${INPUT_DESTINATION}" >> $GITHUB_OUTPUT

# - name: Assert develop branch TODO: Uncomment before merging
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be uncommented before merging

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job @graeme! Remember to remove parts that need to be removed before merging and save your changes 😆

@graeme graeme merged commit af47959 into develop Sep 20, 2023
@graeme graeme deleted the graeme/ios-nightly-alphas branch September 20, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants