Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cleanup of observations.db #2010

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Sep 14, 2023

Task/Issue URL: https://app.asana.com/0/414709148257752/1205463416606413/f
Tech Design URL:
CC:

Description:
Adds an additional path to check for location of observations.db

Steps to test this PR:

  1. Testing on device, enable App Privacy Report if not already enabled (iOS Settings > Privacy & Security > App Privacy Report)
  2. In the app visit a number of sites that make a lot of calls to other urls e.g. cnbc.com, bloomberg.com, cnn.com
  3. Go back to the App Privacy Report and the activity should all be logged there
  4. In Xcode download the container for the app and navigate to observations.db (should be in /AppData/Library/WebKit/WebsiteData/ResourceLoadStatistics)
  5. Check the data stored in the db either using an app like DB Browser for SQLite or by running this command in terminal sqlite3 observations.db "select (select COUNT(*) FROM ObservedDomains)" and note the row count
  6. In the app, tap the burn button
  7. Go back to the App Privacy Report and almost everything should be cleared (there may be 1 or 2 leftovers but it shouldn't be many).
  8. Navigate back to the app and then back to App Privacy Report and confirm there is no change in the data reported from the previous step (except maybe some DDG api calls)
  9. Download the app container again and confirm that observations.db is now empty

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 requested a review from samsymons September 14, 2023 11:55
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working perfectly for me, nice work!

@amddg44 amddg44 merged commit 2ff12f2 into develop Sep 18, 2023
8 checks passed
@amddg44 amddg44 deleted the anya/fix-privacy-report-burn branch September 18, 2023 07:32
@amddg44 amddg44 restored the anya/fix-privacy-report-burn branch September 18, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants