Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1204818349335868/f
Tech Design URL:
CC:
Description:
Allows us to measure the impact of returning users on retention.
Steps to test this PR:
Happy flow:
develop
at least once.requestExti
function (or you can use a proxy to see the call to the /exit endpoint)ru
variant, e.g.v395-2ru
pixel
.Pixel fired m_return_user ["old_atb": "v395-2", "new_atb": "v395-2"]
(variant is not included)xcrun simctl erase all
and run the app again.ru
variant on the call to /exti and there should be nom_return_user
pixel.Update ATB (ie an old install gets generalised):
ReturnUserMeasurement.updateStoredATB
atb.js
return the following json:{ "majorVersion": 395, "for_more_info": "https://duck.co/help/privacy/atb", "version": "v395-3", "minorVersion": 3, "updateVersion": "v20-1" }
Return User Pixel accuracy:
atb.js
return the following json:{ "majorVersion": 400, "for_more_info": "https://duck.co/help/privacy/atb", "version": "v400-1", "minorVersion": 1 }
Pixel fired m_return_user ["old_atb": "v395-2", "new_atb": "v400-1"]
(variant is not included and new atb is from the JSON supplied in the https breakpoint)Debug pixels:
ReturnUserMeasurement.writeSecureATB
and add a nonsense attribute, e.g."none": "sense"
.m_debug_return_user_add_atb
pixel with an error code parameter.ReturnUserMeasurement.writeSecureATB
and add a nonsense attribute, e.g."none": "sense"
.m_debug_return_user_update_atb
pixel with an error code parameter.ReturnUserMeasurement.readSecureATB
and replacekSecMatchLimitOne
with"rubbish"
.m_debug_return_user_read_atb
pixel with an error code parameter.Device Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template