Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement config changes to UA #2037

Merged
merged 8 commits into from
Oct 3, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
162 changes: 157 additions & 5 deletions Core/UserAgentManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,16 @@ public class DefaultUserAgentManager: UserAgentManager {
}

struct UserAgent {

private enum DefaultPolicy: String {

case ddg
case ddgFixed
case closest

}

private struct Constants {
private enum Constants {
// swiftlint:disable line_length
static let fallbackWekKitVersion = "605.1.15"
static let fallbackSafariComponent = "Safari/\(fallbackWekKitVersion)"
Expand All @@ -96,6 +104,16 @@ struct UserAgent {

static let uaOmitSitesConfigKey = "omitApplicationSites"
static let uaOmitDomainConfigKey = "domain"

static let defaultPolicyConfigKey = "defaultPolicy"
static let ddgDefaultSitesConfigKey = "ddgDefaultSites"
static let ddgFixedSitesConfigKey = "ddgFixedSites"

static let closestUserAgentConfigKey = "closestUserAgent"
static let ddgFixedUserAgentConfigKey = "ddgFixedUserAgent"

static let uaVersionsKey = "versions"
static let uaStateKey = "state"
// swiftlint:enable line_length
}

Expand All @@ -110,12 +128,15 @@ struct UserAgent {
private let versionComponent: String
private let safariComponent: String
private let applicationComponent = "DuckDuckGo/\(AppVersion.shared.majorVersionNumber)"
private let statistics: StatisticsStore
private let isTesting: Bool = ProcessInfo().arguments.contains("testing")

init(defaultAgent: String = Constants.fallbackDefaultAgent) {
init(defaultAgent: String = Constants.fallbackDefaultAgent, statistics: StatisticsStore = StatisticsUserDefaults()) {
versionComponent = UserAgent.createVersionComponent(fromAgent: defaultAgent)
baseAgent = UserAgent.createBaseAgent(fromAgent: defaultAgent, versionComponent: versionComponent)
baseDesktopAgent = UserAgent.createBaseDesktopAgent(fromAgent: defaultAgent, versionComponent: versionComponent)
safariComponent = UserAgent.createSafariComponent(fromAgent: baseAgent)
self.statistics = statistics
}

private func omitApplicationSites(forConfig config: PrivacyConfiguration) -> [String] {
Expand All @@ -124,23 +145,139 @@ struct UserAgent {

return omitApplicationObjs.map { $0[Constants.uaOmitDomainConfigKey] ?? "" }
}

public func agent(forUrl url: URL?, isDesktop: Bool,

private func defaultPolicy(forConfig config: PrivacyConfiguration) -> DefaultPolicy {
let uaSettings = config.settings(for: .customUserAgent)
guard let policy = uaSettings[Constants.defaultPolicyConfigKey] as? String else { return .ddg }

return DefaultPolicy(rawValue: policy) ?? .ddg
}

private func ddgDefaultSites(forConfig config: PrivacyConfiguration) -> [String] {
let uaSettings = config.settings(for: .customUserAgent)
let defaultSitesObjs = uaSettings[Constants.ddgDefaultSitesConfigKey] as? [[String: String]] ?? []

return defaultSitesObjs.map { $0[Constants.uaOmitDomainConfigKey] ?? "" }
}

private func ddgFixedSites(forConfig config: PrivacyConfiguration) -> [String] {
let uaSettings = config.settings(for: .customUserAgent)
let fixedSitesObjs = uaSettings[Constants.ddgFixedSitesConfigKey] as? [[String: String]] ?? []

return fixedSitesObjs.map { $0[Constants.uaOmitDomainConfigKey] ?? "" }
}

private func closestUserAgentVersions(forConfig config: PrivacyConfiguration) -> [String] {
let uaSettings = config.settings(for: .customUserAgent)
let closestUserAgent = uaSettings[Constants.closestUserAgentConfigKey] as? [String: Any] ?? [:]
let versions = closestUserAgent[Constants.uaVersionsKey] as? [String] ?? []
return versions
}

private func ddgFixedUserAgentVersions(forConfig config: PrivacyConfiguration) -> [String] {
let uaSettings = config.settings(for: .customUserAgent)
let fixedUserAgent = uaSettings[Constants.ddgFixedUserAgentConfigKey] as? [String: Any] ?? [:]
let versions = fixedUserAgent[Constants.uaVersionsKey] as? [String] ?? []
return versions
}

public func agent(forUrl url: URL?,
isDesktop: Bool,
privacyConfig: PrivacyConfiguration = ContentBlocking.shared.privacyConfigurationManager.privacyConfig) -> String {

guard privacyConfig.isEnabled(featureKey: .customUserAgent) else { return oldLogic(forUrl: url,
isDesktop: isDesktop,
privacyConfig: privacyConfig) }

if ddgDefaultSites(forConfig: privacyConfig).contains(where: { domain in
url?.isPart(ofDomain: domain) ?? false
}) { return oldLogic(forUrl: url, isDesktop: isDesktop, privacyConfig: privacyConfig) }

if ddgFixedSites(forConfig: privacyConfig).contains(where: { domain in
url?.isPart(ofDomain: domain) ?? false
}) { return ddgFixedLogic(forUrl: url, isDesktop: isDesktop, privacyConfig: privacyConfig) }

if closestUserAgentVersions(forConfig: privacyConfig).contains(statistics.atbWeek ?? "") {
return closestLogic(forUrl: url, isDesktop: isDesktop, privacyConfig: privacyConfig)
}

if ddgFixedUserAgentVersions(forConfig: privacyConfig).contains(statistics.atbWeek ?? "") {
return ddgFixedLogic(forUrl: url, isDesktop: isDesktop, privacyConfig: privacyConfig)
}

switch defaultPolicy(forConfig: privacyConfig) {
case .ddg: return oldLogic(forUrl: url, isDesktop: isDesktop, privacyConfig: privacyConfig)
case .ddgFixed: return ddgFixedLogic(forUrl: url, isDesktop: isDesktop, privacyConfig: privacyConfig)
case .closest: return closestLogic(forUrl: url, isDesktop: isDesktop, privacyConfig: privacyConfig)
}
}

private func oldLogic(forUrl url: URL?,
isDesktop: Bool,
privacyConfig: PrivacyConfiguration) -> String {
let omittedSites = omitApplicationSites(forConfig: privacyConfig)
let customUAEnabled = privacyConfig.isEnabled(featureKey: .customUserAgent)

let omitApplicationComponent = !customUAEnabled || omittedSites.contains { domain in
url?.isPart(ofDomain: domain) ?? false
}

let resolvedApplicationComponent = !omitApplicationComponent ? applicationComponent : nil

if isDesktop {
return concatWithSpaces(baseDesktopAgent, resolvedApplicationComponent, safariComponent)
} else {
return concatWithSpaces(baseAgent, resolvedApplicationComponent, safariComponent)
}
}

private func ddgFixedLogic(forUrl url: URL?,
isDesktop: Bool,
privacyConfig: PrivacyConfiguration) -> String {
let omittedSites = omitApplicationSites(forConfig: privacyConfig)
let omitApplicationComponent = omittedSites.contains { domain in
url?.isPart(ofDomain: domain) ?? false
}
let resolvedApplicationComponent = !omitApplicationComponent ? applicationComponent : nil

var defaultSafari = closestLogic(forUrl: url, isDesktop: isDesktop, privacyConfig: privacyConfig)
// If the UA should have DuckDuckGo append it prior to Safari
if let resolvedApplicationComponent {
if let index = defaultSafari.range(of: "Safari")?.lowerBound {
defaultSafari.insert(contentsOf: resolvedApplicationComponent + " ", at: index)
}
}
return defaultSafari
}

private func closestLogic(forUrl url: URL?,
isDesktop: Bool,
privacyConfig: PrivacyConfiguration) -> String {
guard shouldUseUpdateLogic else {
return oldLogic(forUrl: url, isDesktop: isDesktop, privacyConfig: privacyConfig)
}

if isDesktop {
return "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.5 Safari/605.1.15"
}
var deviceProfile = "iPhone; CPU iPhone OS 16_6 like Mac OS X"
if baseAgent.contains("iPad") {
deviceProfile = "iPad; CPU OS 16_6 like Mac OS X"
} else if baseAgent.contains("iPod") {
deviceProfile = "iPod touch; CPU iPhone 16_6 like Mac OS X"
}
return "Mozilla/5.0 (" + deviceProfile + ") AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.5 Mobile/15E148 Safari/604.1"
}

private var shouldUseUpdateLogic: Bool {
// Unfortunately you can't combine #available with any other condition in the same line
if isTesting {
return true
} else if #available(iOS 16.6, *) {
return true
}
return false
}

private func concatWithSpaces(_ elements: String?...) -> String {
return elements
Expand Down Expand Up @@ -205,3 +342,18 @@ struct UserAgent {
}

}

private extension StatisticsStore {

var atbWeek: String? {
guard let atb else { return nil }
let trimmed = String(atb.dropFirst())

if let hyphenIndex = trimmed.firstIndex(of: "-") {
return String(trimmed.prefix(upTo: hyphenIndex))
} else {
return trimmed
}
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
},
{
"package": "TrackerRadarKit",
"repositoryURL": "https://github.com/duckduckgo/TrackerRadarKit.git",
"repositoryURL": "https://github.com/duckduckgo/TrackerRadarKit",
"state": {
"branch": null,
"revision": "4684440d03304e7638a2c8086895367e90987463",
Expand Down
Loading