Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix 7.90.1 #2039

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Hotfix 7.90.1 #2039

merged 2 commits into from
Sep 26, 2023

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1205575101456370/f
Tech Design URL:
CC: @miasma13 @jaceklyp @Bunn

Description:

Fixes an iOS 15 crash.

Steps to test this PR:

  1. Update RemoteMessageRequest.endpoint with the following entry:
return URL(string: "https://raw.githubusercontent.com/duckduckgo/remote-messaging-config/dc43c4359a50e0364002c210beb33f9beb427b8a/live/ios-config/ios-config.json")!

Next, run iOS 15, 16, and 17 simulators and verify that all work correctly. You should only see a remote message on 16 and 17, not 15.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

This is temporary while we find the correct solution for iOS 15.
@samsymons samsymons requested a review from miasma13 September 25, 2023 20:50
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS 15, LGTM

@samsymons samsymons merged commit b847336 into main Sep 26, 2023
9 checks passed
@samsymons samsymons deleted the hotfix/7.90.1 branch September 26, 2023 01:43
samsymons added a commit that referenced this pull request Sep 26, 2023
* tag '7.90.1':
  Hotfix 7.90.1 (#2039)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants