Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for WebCacheManager crash #2042

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Sep 26, 2023

Task/Issue URL: https://app.asana.com/0/414709148257752/1205581661098084/f
Tech Design URL:
CC:

Description:
Fix for occasional crash that is happening when attempting to clear observations.db as part of tapping the fire button

Steps to test this PR:

  1. Testing on device visit a few websites
  2. In the app go to Settings > Debug > File Size Inspector > Application Container > Library > WebKit > WebsiteData > ResourceLoadStatistics and tap on observations.db and confirm the tables have content reporting websites visited
  3. Tap the fire button and confirm the app does not crash
  4. Check the contents of observations.db again and confirm all the tables are now empty
  5. Tap the fire button a couple of more times confirming that there is no crash

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 requested a review from jaceklyp September 26, 2023 16:55
@jaceklyp jaceklyp merged commit dc15e7a into develop Sep 26, 2023
10 checks passed
@jaceklyp jaceklyp deleted the anya/fix-webcachemanager-crash branch September 26, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants