Enabled always-on by default #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
commented
Sep 26, 2023
| @@ -98,7 +98,7 @@ public struct UserDefaultsWrapper<T> { | |||
|
|
|||
| case syncEnvironment = "com.duckduckgo.ios.sync-environment" | |||
|
|
|||
| case networkProtectionDebugOptionAlwaysOnEnabled = "com.duckduckgo.network-protection.always-on.enabled" | |||
| case networkProtectionDebugOptionAlwaysOnDisabled = "com.duckduckgo.network-protection.always-on.disabled" | |||
There was a problem hiding this comment.
Changing the user default so that it will be ON by default for existing users. In any case the change makes sense IMO since the default is now going to be ON, so the presence of this will most likely indicate that the user disabled always on.
diegoreymendez
commented
Sep 26, 2023
| case .enableAlwaysOn: | ||
| cell.textLabel?.text = "Enable Always On" | ||
| case .toggleAlwaysOn: | ||
| cell.textLabel?.text = "Always On" |
There was a problem hiding this comment.
Changed the name since the tick in the debug menu options indicates whether this is ON or OFF.
diegoreymendez
commented
Sep 26, 2023
| @@ -54,7 +54,7 @@ final class NetworkProtectionDebugViewController: UITableViewController { | |||
| } | |||
|
|
|||
| enum DebugFeatureRows: Int, CaseIterable { | |||
| case enableAlwaysOn | |||
| case toggleAlwaysOn | |||
There was a problem hiding this comment.
This case is really for toggling always on, not enabling it.
graeme
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205573532958049/f
Description:
In this PR we enable always on by default, and change the debug menu option's title to just "Always On".
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template