Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore form factor specific favorites if they're received in Sync response #2083

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Oct 10, 2023

Task/Issue URL: https://app.asana.com/0/414235014887631/1205688495536992/f

Description:
Until FFS favorites support is released, deliberately ignore any FFS
favorites folders received in Sync response.

Steps to test this PR:
Refer to BSK PR for testing instructions.


Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy self-assigned this Oct 10, 2023
@ayoy ayoy marked this pull request as ready for review October 10, 2023 11:31
@ayoy ayoy requested a review from bwaresiak October 10, 2023 11:31
@ayoy ayoy assigned bwaresiak and unassigned ayoy Oct 10, 2023
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayoy ayoy assigned ayoy and unassigned bwaresiak Oct 12, 2023
@ayoy ayoy merged commit e8e7fc7 into develop Oct 12, 2023
9 checks passed
@ayoy ayoy deleted the dominik/sync-ignore-ffs-favorites branch October 12, 2023 15:47
samsymons added a commit that referenced this pull request Oct 27, 2023
* develop: (28 commits)
  Update BSK with autofill 9.0.0 (#2103)
  Add an “Open VPN Settings” quick action (#2089)
  bump BSK (changed dashboard API) (#2111)
  Integrate BSK changes (#2101)
  bump bsk for duckplayer fixes on BigSur (#2106)
  iOS VPN Settings part 1 (#2109)
  Release 7.94.0 (#2107)
  Append build number to metricKit crash version (#2100)
  Disable NetP errors temporarily (#2102)
  NetP: Fix server location formatting (#2099)
  address bar position (#2072)
  Fix privacy tests (#2097)
  Add note about Danger matching rules (#2087)
  Release 7.93.0 (#2096)
  Release 7.93.0 (#2096)
  Update tabs tests (#2088)
  Ignore form factor specific favorites if they're received in Sync response (#2083)
  Update BSK with autofill 8.4.2 (#2084)
  Bump C-S-S to 4.39.0 (#2085)
  BSK hotfix 80.3.0-1 merged to the main branch (#2079)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants