Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an “Open VPN Settings” quick action #2089

Merged
merged 9 commits into from
Oct 27, 2023
Merged

Add an “Open VPN Settings” quick action #2089

merged 9 commits into from
Oct 27, 2023

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Oct 13, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414235014887631/1205784963805147/f
Tech Design URL:
CC: @graeme @diegoreymendez

Description:

This PR adds an iOS VPN quick action.

Steps to test this PR:

  1. Launch a clean debug build of the app without any NetP access (i.e., no auth token) and verify that no quick action appears when you long-press the DDG app icon
  2. Mark yourself as an internal user and authenticate with NetP
  3. Dismiss the settings screen
  4. Go back to the iOS Home Screen and long-press the DDG icon, verify that the "Open VPN Settings" option appears and correctly takes you to the VPN settings screen

Next, test that opening the quick action doesn't re-present UI needlessly.

  1. Open the settings screen (but NOT the NetP screen)
  2. Dismiss the app and use the Open VPN action
  3. Check that the NetP screen is instantly presented
  4. When you have the NetP screen open, dismiss the app and use the Open VPN action
  5. Check that nothing happens, as the NetP screen is already open

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons
Refresh the shortcut status on willResignActive.
8a74193
@samsymons
Merge branch 'develop' into sam/netp-quick-action
e15e3d7 
* develop:
  address bar position (#2072)
  Fix privacy tests (#2097)
  Add note about Danger matching rules (#2087)
  Release 7.93.0 (#2096)
  Update tabs tests (#2088)
@samsymons
Change copy for NetP shortcut.
9d98e82
@samsymons
Merge branch 'develop' into sam/netp-quick-action
bb55e83 
* develop:
  bump BSK (changed dashboard API) (#2111)
  Integrate BSK changes (#2101)
  bump bsk for duckplayer fixes on BigSur (#2106)
  iOS VPN Settings part 1 (#2109)
  Release 7.94.0 (#2107)
  Append build number to metricKit crash version (#2100)
  Disable NetP errors temporarily (#2102)
  NetP: Fix server location formatting (#2099)
  Release 7.93.0 (#2096)
@samsymons
Update copy.
a3c6fee
@samsymons
Add copy to UserText
fd214dd
@samsymons
Avoid dismissing and re-presenting the settings VC unnecessarily.
6e48e92
@samsymons samsymons marked this pull request as ready for review October 23, 2023 13:45
graeme
graeme approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@graeme graeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@samsymons samsymons merged commit 1280d29 into develop Oct 27, 2023
9 checks passed
@samsymons samsymons deleted the sam/netp-quick-action branch October 27, 2023 09:45
samsymons added a commit that referenced this pull request Oct 27, 2023
@samsymons
Merge branch 'develop' into jacek/xcode15
bf9f4d5 
* develop: (28 commits)
  Update BSK with autofill 9.0.0 (#2103)
  Add an “Open VPN Settings” quick action (#2089)
  bump BSK (changed dashboard API) (#2111)
  Integrate BSK changes (#2101)
  bump bsk for duckplayer fixes on BigSur (#2106)
  iOS VPN Settings part 1 (#2109)
  Release 7.94.0 (#2107)
  Append build number to metricKit crash version (#2100)
  Disable NetP errors temporarily (#2102)
  NetP: Fix server location formatting (#2099)
  address bar position (#2072)
  Fix privacy tests (#2097)
  Add note about Danger matching rules (#2087)
  Release 7.93.0 (#2096)
  Release 7.93.0 (#2096)
  Update tabs tests (#2088)
  Ignore form factor specific favorites if they're received in Sync response (#2083)
  Update BSK with autofill 8.4.2 (#2084)
  Bump C-S-S to 4.39.0 (#2085)
  BSK hotfix 80.3.0-1 merged to the main branch (#2079)
  ...
samsymons added a commit that referenced this pull request Nov 9, 2023
@samsymons
Merge branch 'develop' into sam/hack-days-netp-widget
0ec685d 
* develop:
  Release 7.95.0 (#2122)
  Add toggling of NetP Notifications to iOS (#2112)
  Fix for deeplink crash when preparing webview preview (#2116)
  Integrates the latest DBP changes in BSK (#2108)
  Switch to next phase of new experiment for UA (#2118)
  Update BSK with autofill 9.0.0 (#2103)
  Add an “Open VPN Settings” quick action (#2089)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graeme graeme graeme approved these changes

@diegoreymendez diegoreymendez Awaiting requested review from diegoreymendez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @graeme