Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset bookmarks sync timestamp after migrating to FFS favorites #2091

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Oct 13, 2023

Task/Issue URL: https://app.asana.com/0/0/1205710208879158/f

Description:
After migration to form-factor specific favorites is done, reset the timestamp
of bookmarks syncable model to force full remote data fetch to populate
FFS favorites folders that may have previously been skipped.

Steps to test this PR:

  1. Launch the iOS app 1 from Xcode from develop branch.
  2. Sign up to Sync.
  3. Launch the iOS app 2 (maybe use a simulator and a device) from this branch.
  4. Add some favorites to the app 2.
  5. Connect app 2 to app 1's Sync account, display form factor specific favorites (default setting).
  6. Verify that both apps have the same set of favorites.
  7. Delete a favorite on the app 1. Verify that it's not deleted from the app 2 (that displays mobile favorites that were unaffected by a change made on app 1).
  8. Run app 1 from this branch.
  9. Verify that app 1 displays the previously deleted favorite.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy requested a review from bwaresiak October 13, 2023 10:50
@bwaresiak
Copy link
Collaborator

After removing the app and running it again, I've gor a crash (that disappeared afterwards):
cr

I think syncDataProviders can be nil here.

@ayoy
Copy link
Contributor Author

ayoy commented Oct 31, 2023

After removing the app and running it again, I've gor a crash (that disappeared afterwards): cr

I think syncDataProviders can be nil here.

Oops, thanks for spotting this! The only thing that comes to my mind is to pass the flag via a local variable in case syncDataProviders was not initialized. It solves the crash FWIW and sets the flag to true as expected. Please have another look. Thanks!

Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayoy ayoy merged commit dcd4704 into dominik/sync-ffs-favorites Nov 3, 2023
9 checks passed
@ayoy ayoy deleted the dominik/sync-ffs-favorites-reset-bookmarks-timestamp branch November 3, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants