Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync Form Factor specific favorites tests #2164

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

loremattei
Copy link
Contributor

@loremattei loremattei commented Nov 15, 2023

Task/Issue URL: https://app.asana.com/0/1201493110486074/1206024000016000/f
Tech Design URL:
CC:

Description:

Add management of the "Share Favorites" setting to fix the Sync Data test flow.

Note: The GHA trigger is currently set to "Push" to make testing/fixing easier. It will be reverted to the schedule before merging.


Internal references:

Software Engineering Expectations
Technical Design Template

@loremattei loremattei changed the title Ffix sync Form Factor specific favorites tests Fix sync Form Factor specific favorites tests Nov 15, 2023
@loremattei loremattei marked this pull request as ready for review November 24, 2023 14:17
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

@loremattei loremattei merged commit 28c6d98 into develop Nov 24, 2023
10 checks passed
@loremattei loremattei deleted the loremattei/fix-sync-ffs-tests branch November 24, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants