Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing between Waitlist buttons #2228

Closed
wants to merge 1 commit into from

Conversation

graeme
Copy link
Contributor

@graeme graeme commented Dec 6, 2023

Task/Issue URL: https://app.asana.com/0/0/1206111074849454/f

Description:

Yet another spacing tweak. I didn’t measure it properly the first time, but this time it’s definitely correct (Design approved).

Steps to test this PR:

  1. Check that the buttons on the NetP Waitlist landing page are 16px apart.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@graeme graeme requested a review from quanganhdo December 6, 2023 15:36
@graeme graeme changed the title Fix spacing between buttons Fix spacing between Waitlist buttons Dec 6, 2023
Copy link
Member

@quanganhdo quanganhdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaceklyp jaceklyp deleted the branch develop December 6, 2023 15:48
@jaceklyp jaceklyp closed this Dec 6, 2023
@graeme graeme deleted the graeme/netp-waitlist-button-spacing branch December 6, 2023 16:58
@graeme graeme restored the graeme/netp-waitlist-button-spacing branch December 6, 2023 16:58
@graeme graeme deleted the graeme/netp-waitlist-button-spacing branch December 6, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants