Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates BSK #2239

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Updates BSK #2239

merged 4 commits into from
Dec 7, 2023

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Dec 6, 2023

Task/Issue URL: https://app.asana.com/0/0/1206114617364817/f

BSK PR: duckduckgo/BrowserServicesKit#594
macOS PR: duckduckgo/macos-browser#1934

Description

We no longer exclude 10.0.0.0/8 from the VPN since it was causing our DNS to be excluded as well.

Testing:

  1. Connect the VPN
  2. Make sure it works
  3. Download a traceroute app for iOS and make sure the route for 10.11.12.1 goes through our tunnel.

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

# By Graeme Arthur
# Via GitHub
* main:
  Add Geoswitching pixels (#2235)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons pushed a commit to duckduckgo/BrowserServicesKit that referenced this pull request Dec 6, 2023
Task/Issue URL: https://app.asana.com/0/0/1206114617364818/f

iOS PR: duckduckgo/iOS#2239
macOS PR: duckduckgo/macos-browser#1934

Description

We no longer exclude 10.0.0.0/8 from the VPN since it was causing our DNS to be excluded as well.
@samsymons samsymons merged commit 5b605a3 into main Dec 7, 2023
10 checks passed
@samsymons samsymons deleted the diego/fix-vpn-dns-routing branch December 7, 2023 00:12
samsymons added a commit that referenced this pull request Dec 7, 2023
* main:
  Updates BSK (#2239)
  Add Geoswitching pixels (#2235)
  Fix spacing between buttons (#2237)
  Update all references to develop branch with main (#2231)
  Update TRK (#2200)
  Breakage report improvements (#2197)
  Update BSK reference to include the disable rekeying flag (#2219)
  Final NetP ship review feedback (#2221)
  Improve handling lists in Sync (#2192)
  remove address bar position pixels (#2220)
samsymons added a commit that referenced this pull request Dec 7, 2023
# By Graeme Arthur (3) and others
# Via GitHub
* main:
  Updates BSK (#2239)
  Add Geoswitching pixels (#2235)
  Fix spacing between buttons (#2237)
  Update all references to develop branch with main (#2231)
  Update TRK (#2200)
  Breakage report improvements (#2197)
  Update BSK reference to include the disable rekeying flag (#2219)
  Final NetP ship review feedback (#2221)
  Improve handling lists in Sync (#2192)
  remove address bar position pixels (#2220)

# Conflicts:
#	DuckDuckGo.xcodeproj/xcshareddata/xcschemes/DuckDuckGo.xcscheme
samsymons pushed a commit to duckduckgo/BrowserServicesKit that referenced this pull request Dec 7, 2023
Task/Issue URL: https://app.asana.com/0/0/1206114617364818/f

iOS PR: duckduckgo/iOS#2239
macOS PR: duckduckgo/macos-browser#1934

Description

We no longer exclude 10.0.0.0/8 from the VPN since it was causing our DNS to be excluded as well.
samsymons added a commit that referenced this pull request Dec 9, 2023
* main:
  Report macOS NetP connection attempts & tunnel failures (#2234)
  Always use black and white colors for the QR code (#2248)
  Update BSK with autofill 10.0.1 (#2245)
  Ensure that LinkPresentation framework is called on main thread (#2241)
  expose window.print handler to page world (#2243)
  Updates BSK (#2239)
  Add Geoswitching pixels (#2235)
  Fix spacing between buttons (#2237)
  Update all references to develop branch with main (#2231)
  Update TRK (#2200)
  Breakage report improvements (#2197)
samsymons added a commit that referenced this pull request Dec 11, 2023
* main:
  Enable NetP in production builds (#2232)
  Report macOS NetP connection attempts & tunnel failures (#2234)
  Always use black and white colors for the QR code (#2248)
  Update BSK with autofill 10.0.1 (#2245)
  Ensure that LinkPresentation framework is called on main thread (#2241)
  expose window.print handler to page world (#2243)
  Updates BSK (#2239)
  Add Geoswitching pixels (#2235)
  Fix spacing between buttons (#2237)
  Update all references to develop branch with main (#2231)
  Update TRK (#2200)
  Breakage report improvements (#2197)
  Update BSK reference to include the disable rekeying flag (#2219)
  Final NetP ship review feedback (#2221)
  Improve handling lists in Sync (#2192)
  remove address bar position pixels (#2220)
  Address Bar Spoofing Tests + Remediation (#2181)
  Update Sync e2e tests to fit the new UI (#2215)
  NetP waitlist final touches (#2209)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants