-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Top Level Settings to SwiftUI + Other improvements #2255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, I really appreciate your diligence in the approach.
Please take a look at the comments, nothing critical, couple of typos. Besides these I would also:
- Check and fix indentation and empty lines (especially in the files for respective sections)
- Perform (if you haven't) more in-depth testing for older iOS versions: iOS 16, iOS 15 and iOS 14 (especially if we will merge before dropping this version to make sure we won't introduce anything breaking in the last version for 14).
@miasma13 I’ve addressed your feedback, but I’m not sure why you’ve blocked the PR given suggestions are about a few typos and code style. Is there anything else I missed? |
43c877e
to
f59497d
Compare
Task/Issue URL: https://app.asana.com/0/1204099484721401/1206108402009442
Description
Getting rid of the old and ugly SettingsViewController and the related Static Storyboard View, alongside a few other changes as follows:
NavigationViewController
to prevent breakage of theme and functionalityDesignResourcesKit
to render SettingsHow to test