Release 7.101.0.1 #2262
Merged
Release 7.101.0.1 #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task/Issue URL: https://app.asana.com/0/0/1206136376883995/f Tech Design URL: CC: Description: This PR fixes IPv6 connectivity.
Task/Issue URL: https://app.asana.com/0/72649045549333/1206057769488160/f Description: Add iOS NetP pixels for active/new user, VPN enabled success rate, tunnel failure/recovery, and latency. Steps to test this PR: Confirm pixel submission on Kibana Make sure active user pixel includes the cohort value
|
This change fixes IPv6 connectivity and improves pixels ahead of the NetP waitlist test. |
graeme
reviewed
Dec 13, 2023
| @@ -127,7 +127,8 @@ class SettingsViewController: UITableViewController { | |||
| private lazy var shouldShowNetPCell: Bool = { | |||
| #if NETWORK_PROTECTION | |||
| if #available(iOS 15, *) { | |||
| return featureFlagger.isFeatureOn(.networkProtection) | |||
| let accessController = NetworkProtectionAccessController() | |||
There was a problem hiding this comment.
oh!, no more feature flagging @graeme? Here's where this logic has moved:
Should we kill the feature flag check from here?
|
@samsymons Tried to build an AdHoc build but ended up with an invalid bundle. Not sure if that’s something worth looking into... |
graeme
approved these changes
Dec 13, 2023
samsymons
added a commit
that referenced
this pull request
Dec 21, 2023
* main: (35 commits) Add Sync feature flags (#2279) Add Sync Success Rate pixel (#2277) add test 5 and fix test 4 (#2276) Fix: "SwiftLintPlugin" must be enabled before it can be used (#2274) Send WG invalid state reason (#2275) Typo Fix: "SwiftLintPlugin" must be enabled before it can be used Release 7.102.0 (#2273) Add search retention pixel for NetP (#2267) Run sync tests in matrix (#2263) SwiftLint build plugin (#2233) Update VPN active user check and debug options (#2269) Update Autofill Logins copy (#2246) Remove the reconnect/disconnect logic from the connection tester (#2272) Remove the Fastlane notes file temporarily (#2270) remove QR code from save recovery PDF view (#2271) Show dev environment indicator in Sync Settings (#2265) Release 7.101.0.1 (#2262) Sync Flow Error Handling (#2264) Fix fingerprinting UI tests (#2252) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure all GH checks passed before merging. It can take around 20 minutes.
Briefly review this PR to see if there are no issues or red flags and then merge it.