Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Link Tracking Protection to preserve headers #2268

Merged
merged 5 commits into from
Dec 22, 2023
Merged

Update Link Tracking Protection to preserve headers #2268

merged 5 commits into from
Dec 22, 2023

Conversation

SlayterDev
Copy link
Contributor

@SlayterDev SlayterDev commented Dec 13, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1163321984198618/1202368115363949/f
Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. Clone https://github.com/duckduckgo/privacy-test-pages on brad/header-drop-test and serve the root directory locally
  2. Navigate to http://localhost:3000/privacy-protections/query-parameters/
  3. Ensure the tests pass ok
  4. Set a breakpoint in TabViewController.swift on Line 1331
  5. Click a link in the test page
  6. In the debug console execute po navigationAction.request.allHTTPHeaders then po newRequest.allHTTPHeaders and ensure they are the same.

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
Internal references:

Software Engineering Expectations
Technical Design Template

@SlayterDev SlayterDev self-assigned this Dec 13, 2023
@SlayterDev SlayterDev mentioned this pull request Dec 13, 2023
Merged
6 tasks
@SlayterDev SlayterDev marked this pull request as ready for review December 13, 2023 19:19
bwaresiak
bwaresiak approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just make sure to fix linter issues :)

@SlayterDev SlayterDev merged commit 8adab58 into main Dec 22, 2023
9 of 10 checks passed
@SlayterDev SlayterDev deleted the brad/headers-fix branch December 22, 2023 15:30
samsymons added a commit that referenced this pull request Dec 22, 2023
@samsymons
Merge branch 'main' into jacek/xcode15
251b470 
* main:
  Update Link Tracking Protection to preserve headers (#2268)
  Custom config URL (#2278)
  Fix internal user toggling (#2282)
  Display warning icon in Sync Settings cell when data syncing is disabled (#2281)
samsymons added a commit that referenced this pull request Dec 24, 2023
@samsymons
Merge branch 'main' into sam/add-netp-subscription-auth-support
9090b68 
# By Sam Symons (2) and others
# Via GitHub
* main:
  Fix alpha builds (#2293)
  Update latency & tunnel failure monitor implementation (#2290)
  Prevents VPNSettings from reporting fake changes (#2288)
  Fix SwiftLint violations (#2289)
  Disable parallel run for sync critical tests (#2287)
  Update Link Tracking Protection to preserve headers (#2268)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaresiak bwaresiak bwaresiak approved these changes

Assignees

@SlayterDev SlayterDev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SlayterDev @bwaresiak