Display warning icon in Sync Settings cell when data syncing is disabled #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are supposed to show the warning in the settings cell. |
ayoy
commented
Dec 21, 2023
| @@ -113,7 +113,7 @@ class SettingsViewController: UITableViewController { | |||
| } | |||
|
|
|||
| private var shouldShowSyncCell: Bool { | |||
| return syncService.featureFlags.contains(.userInterface) || internalUserDecider.isInternalUser | |||
There was a problem hiding this comment.
the || internalUserDecider.isInternalUser is a remainder from the original feature flags PR when we were supposed to show the UI to internal users anyway, even if Sync top-level feature flag is disabled. We've replaced that on Apple platforms by setting top-level flag to "internal", so this code shouldn't end up here.
SabrinaTardio
approved these changes
Dec 21, 2023
samsymons
added a commit
that referenced
this pull request
Dec 22, 2023
# By Sam Symons (13) and others # Via Bartek Waresiak (2) and others * main: (69 commits) Custom config URL (#2278) Fix internal user toggling (#2282) Display warning icon in Sync Settings cell when data syncing is disabled (#2281) Add Sync feature flags (#2279) Add Sync Success Rate pixel (#2277) add test 5 and fix test 4 (#2276) Fix: "SwiftLintPlugin" must be enabled before it can be used (#2274) Send WG invalid state reason (#2275) Typo Fix: "SwiftLintPlugin" must be enabled before it can be used Release 7.102.0 (#2273) Add search retention pixel for NetP (#2267) Run sync tests in matrix (#2263) SwiftLint build plugin (#2233) Update VPN active user check and debug options (#2269) Update Autofill Logins copy (#2246) Remove the reconnect/disconnect logic from the connection tester (#2272) Remove the Fastlane notes file temporarily (#2270) remove QR code from save recovery PDF view (#2271) Show dev environment indicator in Sync Settings (#2265) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206213106333863/f
Steps to test this PR:
Verify disabling L1 feature flag according to the spec.
Internal references:
Software Engineering Expectations
Technical Design Template