Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable parallel run for sync critical tests #2287

Merged

Conversation

loremattei
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414709148257752/1206227746400032/f
Tech Design URL:
CC:

Description:
We've seen some failures when running tests in parallel.
Let's try and run them sequentially to validate the current hypothesis.

Steps to test this PR:

  1. Check CI is green.

Internal references:

Software Engineering Expectations
Technical Design Template

@loremattei loremattei marked this pull request as ready for review December 22, 2023 15:48
@loremattei loremattei changed the title Loremattei/disable parallel run for sync critical tests Disable parallel run for sync critical tests Dec 22, 2023
@loremattei loremattei merged commit b658d21 into main Dec 22, 2023
11 of 12 checks passed
@loremattei loremattei deleted the loremattei/disable-parallel-run-for-sync-critical-tests branch December 22, 2023 16:24
samsymons added a commit that referenced this pull request Dec 24, 2023
* main:
  Fix alpha builds (#2293)
  Update latency & tunnel failure monitor implementation (#2290)
  Prevents VPNSettings from reporting fake changes (#2288)
  Fix SwiftLint violations (#2289)
  Disable parallel run for sync critical tests (#2287)
samsymons added a commit that referenced this pull request Dec 24, 2023
# By Sam Symons (2) and others
# Via GitHub
* main:
  Fix alpha builds (#2293)
  Update latency & tunnel failure monitor implementation (#2290)
  Prevents VPNSettings from reporting fake changes (#2288)
  Fix SwiftLint violations (#2289)
  Disable parallel run for sync critical tests (#2287)
  Update Link Tracking Protection to preserve headers (#2268)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants