Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents VPNSettings from reporting fake changes #2288

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Dec 22, 2023

Task/Issue URL: https://app.asana.com/0/0/1206212872939261/f

macOS PR: duckduckgo/macos-browser#2004
BSK PR: duckduckgo/BrowserServicesKit#614

Description

Makes some changes to VPNSettings so that it won't publish fake settings updates.

Testing

  1. Run the app
  2. Connect NetP and make sure everything works fine.
  3. Ensure changing location works.
  4. Ensure "Exclude local networks" works. You may need an app to do a traceroute.

Internal references:

Software Engineering Expectations
Technical Design Template

@diegoreymendez diegoreymendez self-assigned this Dec 22, 2023
@diegoreymendez diegoreymendez marked this pull request as ready for review December 22, 2023 16:30
@diegoreymendez diegoreymendez changed the title Diego/fix fake settings update Prevents VPNSettings from reporting fake changes Dec 22, 2023
@@ -169,7 +169,6 @@ class ConfigurationDebugViewController: UITableViewController {
}
}

// swiftlint:disable:next cyclomatic_complexity
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was triggering a swiftlint alert. I didn't introduce it but it was failing in the CI tests so I have to address this here.

diegoreymendez added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Dec 22, 2023
Task/Issue URL:  https://app.asana.com/0/0/1206212872939261/f

iOS PR: duckduckgo/iOS#2288
macOS PR: duckduckgo/macos-browser#2004
What kind of version bump will this require?: Patch

## Description

Makes some changes to `VPNSettings` so that it won't publish fake settings updates.
@diegoreymendez diegoreymendez merged commit 64f2dd2 into main Dec 22, 2023
10 checks passed
@diegoreymendez diegoreymendez deleted the diego/fix-fake-settings-update branch December 22, 2023 20:44
diegoreymendez added a commit to duckduckgo/macos-browser that referenced this pull request Dec 22, 2023
Task/Issue URL: https://app.asana.com/0/0/1206212872939261/f

iOS PR: duckduckgo/iOS#2288
BSK PR: duckduckgo/BrowserServicesKit#614

## Description

Makes some changes to VPNSettings so that it won't publish fake settings
updates.

Also changes main App's startup behaviour slightly so that the VPN menu
app will relaunch every time the main app launches (for debug builds
only). This is to make testing easier.
samsymons added a commit that referenced this pull request Dec 24, 2023
* main:
  Fix alpha builds (#2293)
  Update latency & tunnel failure monitor implementation (#2290)
  Prevents VPNSettings from reporting fake changes (#2288)
  Fix SwiftLint violations (#2289)
  Disable parallel run for sync critical tests (#2287)
samsymons added a commit that referenced this pull request Dec 24, 2023
# By Sam Symons (2) and others
# Via GitHub
* main:
  Fix alpha builds (#2293)
  Update latency & tunnel failure monitor implementation (#2290)
  Prevents VPNSettings from reporting fake changes (#2288)
  Fix SwiftLint violations (#2289)
  Disable parallel run for sync critical tests (#2287)
  Update Link Tracking Protection to preserve headers (#2268)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants