Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alpha builds #2293

Merged
merged 3 commits into from
Dec 23, 2023
Merged

Fix alpha builds #2293

merged 3 commits into from
Dec 23, 2023

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1206232666277835/f
Tech Design URL:
CC: @quanganhdo

Description:

This PR fixes alpha build generation.

Steps to test this PR:

  1. Check the example workflow run provided and make sure it succeeded

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from quanganhdo December 23, 2023 03:45
Copy link
Member

@quanganhdo quanganhdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go when the assertion is added back up.

@samsymons samsymons merged commit 2db949c into main Dec 23, 2023
10 checks passed
@samsymons samsymons deleted the sam/fix-alpha-builds branch December 23, 2023 04:10
samsymons added a commit that referenced this pull request Dec 24, 2023
* main:
  Fix alpha builds (#2293)
  Update latency & tunnel failure monitor implementation (#2290)
  Prevents VPNSettings from reporting fake changes (#2288)
  Fix SwiftLint violations (#2289)
  Disable parallel run for sync critical tests (#2287)
samsymons added a commit that referenced this pull request Dec 24, 2023
# By Sam Symons (2) and others
# Via GitHub
* main:
  Fix alpha builds (#2293)
  Update latency & tunnel failure monitor implementation (#2290)
  Prevents VPNSettings from reporting fake changes (#2288)
  Fix SwiftLint violations (#2289)
  Disable parallel run for sync critical tests (#2287)
  Update Link Tracking Protection to preserve headers (#2268)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants