Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Checkmark icon to pickers #2337

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Add Checkmark icon to pickers #2337

merged 5 commits into from
Jan 15, 2024

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Jan 14, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/0/1206327436431895/f

Description:

  • Adds a checkmark icon to the picker options in settings (based on design feedback)
  • Fixes missing translations
Screenshot 2024-01-12 at 7 17 48 PM

Steps to test this PR:

  1. Go to Settings
  2. Tap any option that displays a picker (Theme, Fire Button Animation or Address bar Position)
  3. Observe there's a checkmark icon in the selected option
  4. Test with iOS 15.x and observe menus for the above options work
  5. Change device language
  6. Check settings main view is properly translated
Internal references:

Software Engineering Expectations
Technical Design Template

@afterxleep afterxleep requested a review from graeme January 14, 2024 10:17
@brindy
Copy link
Contributor

brindy commented Jan 15, 2024

LGTM fwiw, but I'll let @graeme hit approve.

@github-actions GitHub Actions
Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 8457b0f

brindy
brindy approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a couple of languages and LGTM

@afterxleep afterxleep merged commit 54d76ae into main Jan 15, 2024
10 checks passed
@afterxleep afterxleep deleted the daniel/checkmark-in-picker branch January 15, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

@graeme graeme Awaiting requested review from graeme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afterxleep @brindy