Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh the model after the tab has been closed #2358

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jan 19, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1206390999092189/f
Tech Design URL:
CC:

Description:

Fixes a bug where the current tab wouldn't close properly when requested.

Steps to test this PR:

On iPad:

  1. Open a bunch of tabs
  2. Select the first, close it - should update to the next tab
  3. Select the last, close it - should update to the previous tab
  4. Select a tab in the middle, close it - should update to the previous tab

Smoke test opening and closing tabs on iPhone.

@brindy brindy requested a review from graeme January 19, 2024 14:45
Copy link
Contributor

@graeme graeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced from main and then tested on this branch. Seems fixed. Nice one!

@graeme graeme merged commit dc58945 into release/7.105.0 Jan 19, 2024
10 checks passed
@graeme graeme deleted the brindy/fix-tabs-bar-crash branch January 19, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants