Add rollout for cookie popup management enabled by default #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dus7
commented
Jan 24, 2024
| @@ -229,7 +222,7 @@ extension AutoconsentUserScript { | |||
| return | |||
| } | |||
|
|
|||
| if preferences.autoconsentPromptSeen == true && preferences.autoconsentEnabled == false { | |||
There was a problem hiding this comment.
To make reasoning about this and following changes easier, note autoconsentPromptSeen was set to true after user enabled the feature (https://github.com/duckduckgo/iOS/pull/2373/files#diff-d04b75c0b651987027e4a487112e5facbd38ff7c45b585c5e202b118eaf68b3dL71).
|
Converted back to draft due to additional circumstances mentioned in https://app.asana.com/0/0/1206430574685321/1206433715557448/f |
dus7
changed the title
dus7
changed the title
dus7
changed the title
This was referenced Feb 1, 2024
dus7
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Feb 1, 2024
Task/Issue URL: https://app.asana.com/0/0/1206474382370291/f **Description**: No changes in logic. Subfeature will be used in duckduckgo/iOS#2373 **Steps to test this PR**: No changes in Cookie management settings. --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
samsymons
added a commit
that referenced
this pull request
Feb 8, 2024
# By Mariusz Śpiewak (11) and others # Via Bartek Waresiak (3) and others * main: (52 commits) Release 7.108.0-3 (#2454) User Authentication (#2431) Fix BSK reference to tagged version (#2447) Set proper border color for widgets (#2446) Check subfeature state before reading rollout data (#2426) Remove the mock VPN invite code (#2442) Release 7.108.0-2 (#2445) Keep DuckDuckGo Settings after Fire Button (#2444) Release 7.108.0-1 (#2440) Release 7.107.1-1 (#2439) Updates internal user flag to reset state (#2438) Release 7.107.1-0 (#2437) Hide the debug menu when debug mode is not enabled (#2436) Autoconsent 9.7.2 (#2425) Release 7.108.0-0 (#2432) Autofill: Fix footer sizing for multiline labels (#2422) Add rollout for cookie popup management enabled by default (#2373) Update BSK with autofill 10.1.0 (#2414) Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2408) Add Autoconsent onByDefault subfeature (#2423) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206264112133008/1206441673559117/f
Description:
Adds the incremental rollout for autoconsent being enabled by default.
Removes the Dax dialog used to prompt for enabling the cookie autoconsent feature.
The dialog was disabled due to https://app.asana.com/0/1203936086921904/1204496002772588/f so the UI code was dead anyway.
Rollout steps are controlled by
onByDefaultsubfeature being defined underautoconsent. If the feature is not present, no rollout steps are defined or randomized probability value does not match the rollout, there are no changes to existing behavior.Steps to test this PR:
Test disabled by default when not in rollout
Test rollout is respected when no user setting present
Test user setting is respected