Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daniel/subscriptions/8.itp #2427

Merged
merged 18 commits into from
Feb 9, 2024
Merged

Daniel/subscriptions/8.itp #2427

merged 18 commits into from
Feb 9, 2024

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Feb 2, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/72649045549333/1205043809052693/f
Tech Design URL:
CC:

Description:

  • Implements ITP for subscriptions
  • Implements navigating back in WebViews
  • Shows/Hide navigation bar on WebViews depending on scroll position
  • Subscription WebViews are now shown in a sheet for better navigation/usability
  • Includes several improvements to the subscription flow for memory management and etc.
  • Allows navigating to tel: FaceTime: and etc schemas
  • Properly manages to navigate to new windows

Steps to test this PR:
⚠️ This requires a sandbox account and the alpha version of the app

  1. Get a Subscription
  2. Go to ITP
  3. Navigate between links and views
  4. Check that PDF files can be seen and shared (ℹ️ Downloaded PDF is a dummy file for testing, as real PDF's are behind internal user wall)
Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 2555d4f

@afterxleep afterxleep marked this pull request as ready for review February 8, 2024 05:35
@miasma13 miasma13 self-requested a review February 8, 2024 15:38
miasma13
miasma13 reviewed Feb 8, 2024
View reviewed changes
DuckDuckGo/Subscription/UserScripts/identityTheftRestorationPagesFeature.swift Outdated
@@ -0,0 +1,75 @@
//
// identityTheftRestorationPagesFeature.swift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be uppercased.

miasma13
miasma13 reviewed Feb 8, 2024
View reviewed changes
DuckDuckGo/Subscription/Views/NavigationBarModifier.swift Outdated
// Extension to easily apply the custom modifier

extension View {
func applyNavigationStyle() -> some View {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it used anywhere?

miasma13
miasma13 reviewed Feb 8, 2024
View reviewed changes
DuckDuckGo/Subscription/AsyncHeadlessWebview/HeadlessWebViewCoordinator.swift Outdated
@@ -0,0 +1,138 @@
//
// HeadlessWebviewCoordinator.swift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SwiftLint is angry here.

@afterxleep afterxleep merged commit 18663c3 into main Feb 9, 2024
10 checks passed
@afterxleep afterxleep deleted the daniel/subscriptions/8.itp branch February 9, 2024 14:25
samsymons added a commit that referenced this pull request Feb 12, 2024
@samsymons
Merge branch 'main' into sam/netp-debug-command-disable-vpn
b6fc949 
* main:
  Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2460)
  Fix HomeViewController retain cycle (#2462)
  Fix hotfixing process (#2443)
  Daniel/subscriptions/8.itp (#2427)
  Add strict checking for Asana link in PR description (#2463)
  PR test (#2464)
  swipe tabs (#2370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miasma13 miasma13 miasma13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afterxleep @miasma13