Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple behavior monitoring to better address potential breakage issues #2521

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

jaceklyp
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1206706226010039/f

Description:
We want to identify behavioral signals that indicate a user is experiencing breakage.

Steps to test this PR:

  1. Run UserBehaviorMonitorTests
  2. Go through scenarios listed here: https://app.asana.com/0/0/1206706226010039/f and see if pixels are being sent.

@jaceklyp jaceklyp requested a review from samsymons February 29, 2024 20:28
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested all pixels multiple times, checked the pixel names and that they're called in the correct places, and the edge cases pointed out in the previous PR are deemed acceptable by product, so we're good here once CI is green.

Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes LGTM

@jaceklyp jaceklyp merged commit a4cd443 into release/7.110.0 Feb 29, 2024
13 checks passed
@jaceklyp jaceklyp deleted the jacek/user-behavior-monitoring-2 branch February 29, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants