Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webview leak in performancemetrics #2624

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Fix webview leak in performancemetrics #2624

merged 2 commits into from
Mar 22, 2024

Conversation

SlayterDev
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1206899355242117/f
Tech Design URL:
CC:

Description:

Steps to test this PR:
1.
2.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@SlayterDev SlayterDev self-assigned this Mar 22, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Mar 22, 2024
@SlayterDev SlayterDev marked this pull request as ready for review March 22, 2024 12:08
@SlayterDev SlayterDev removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Mar 22, 2024
@SlayterDev SlayterDev merged commit f2e2c31 into main Mar 22, 2024
13 checks passed
@SlayterDev SlayterDev deleted the brad/webview-leak branch March 22, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants