Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Ship Review issues with entitlement expiration #2628

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

quanganhdo
Copy link
Member

@quanganhdo quanganhdo commented Mar 22, 2024

Task/Issue URL: https://app.asana.com/0/1203137811378537/1206896148261286/f
Tech Design URL:
CC:

Description:

This PR addresses some Ship Review issues with entitlement expiration not being picked up by adding entitlementsDidChange and accountDidSignOut notification handling

Steps to test this PR:

  1. Subscribe to PP
  2. Remove sub from device
  3. VPN should stop and be removed from Settings.app
  4. Revoke the entitlements
  5. Open another app and go back to the app
  6. The app should detect the entitlement change and show messaging & stop the VPN

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Mar 22, 2024
@quanganhdo quanganhdo requested a review from samsymons March 22, 2024 20:44
@quanganhdo quanganhdo removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Mar 22, 2024
@quanganhdo quanganhdo merged commit 07e7aa7 into main Mar 22, 2024
22 of 23 checks passed
@quanganhdo quanganhdo deleted the anh/pp/entitlement-checks branch March 22, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants