iOS: VPN Metadata Improvements #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
diegoreymendez
commented
Apr 25, 2024
| @@ -220,6 +220,9 @@ final class NetworkProtectionPacketTunnelProvider: PacketTunnelProvider { | |||
| } | |||
|
|
|||
| @objc init() { | |||
| let defaults = UserDefaults.networkProtectionGroupDefaults | |||
| NetworkProtectionLastVersionRunStore(userDefaults: defaults).lastExtensionVersionRun = AppVersion.shared.versionAndBuildNumber | |||
There was a problem hiding this comment.
We're now storing the last extension version run, to report it in the metadata.
diegoreymendez
changed the title
diegoreymendez
removed
the
bot: not in app board
graeme
approved these changes
Apr 26, 2024
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Apr 26, 2024
Task/Issue URL: https://app.asana.com/0/0/1206897550778458/f iOS PR: duckduckgo/iOS#2791 macOS PR: duckduckgo/macos-browser#2704 What kind of version bump will this require?: Minor ## Description Adds some improved tracking of tunnel interfaces to include `ipsec` tunnels.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Apr 26, 2024
Task/Issue URL: https://app.asana.com/0/0/1207169059489741/f iOS: duckduckgo/iOS#2791 BSK: duckduckgo/BrowserServicesKit#799 ## Description - Add last IPC, controller, tunnel errors to VPN metadata - Updates VPN feedback metadata to include `ipsec` tunnel count. - Add `lastExtensionVersionRun` to VPN metadata in the App Store build
samsymons
added a commit
that referenced
this pull request
Apr 26, 2024
…utdown # By Christopher Brind (4) and others # Via Chris Brind (1) and others * main: (21 commits) Update BSK to 141.1.1 (#2796) iOS: VPN Metadata Improvements (#2791) Add Internal Page suggestions support (#2784) iOS: Add pixels to track VPN wake and stop attempts (#2785) Fix bug that shows selected tab in strange position in the switcher (#2789) Remove AppTP (#2682) Release 7.117.0-1 (#2794) cherry pick progress bar fix (#2793) fix progress bar missing after cold launch (#2792) Check entitlements before showing VPN screen from notification (#2748) Add parameter allowed encoding to error descriptions (#2781) Update Lottie to 4.4.3 (#2765) Update to fastlane 2.220.0 to fix ad-hoc lane (#2782) iOS: Bundle-Specfic Autofill Secure Vault Keychain Items (#2759) Fix dSYM archive upload to S3 (#2778) Fix dSYM archive upload to S3 (#2778) Release 7.117.0-0 (#2776) Select Subscription Environment in Debug Settings (#2766) lastDisconnectError now matches against NEVPNConnectionError (#2753) Release 7.116.0-3 (#2774) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Apr 30, 2024
* main: (38 commits) Disable the feedback send button when there’s no text (#2800) Release 7.118.0-0 (#2802) Autofill Settings - Import passwords via sync (#2756) Fix selected VPN location consistency (#2797) Reapply "Report Apple Ad attribution using pixel" (#2702) reapply auto clear fix, clear cookies, load page on link click (#2798) Toggle Connect on Demand when receiving user initiated VPN lifecycle events (#2771) Update BSK to 141.1.1 (#2796) iOS: VPN Metadata Improvements (#2791) Add Internal Page suggestions support (#2784) iOS: Add pixels to track VPN wake and stop attempts (#2785) Fix bug that shows selected tab in strange position in the switcher (#2789) Remove AppTP (#2682) Release 7.117.0-1 (#2794) cherry pick progress bar fix (#2793) fix progress bar missing after cold launch (#2792) Check entitlements before showing VPN screen from notification (#2748) Add parameter allowed encoding to error descriptions (#2781) Update Lottie to 4.4.3 (#2765) Update to fastlane 2.220.0 to fix ad-hoc lane (#2782) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207169059489741/f
macOS: duckduckgo/macos-browser#2704
BSK: duckduckgo/BrowserServicesKit#799
Description
Updates VPN feedback metadata to include
ipsectunnel count.Testing
You'd need to test the creation of an
ipsectunnel in iOS, although IMO it would be enough to test that the metadata looks good for your current situation, and reports a tunnel count of 1.Internal references:
Software Engineering Expectations
Technical Design Template