Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to autofill pixels for KPIs #2865

Merged
merged 7 commits into from
May 17, 2024
Merged

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented May 16, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1207338955294273/f
Tech Design URL:
CC:

Description:
Updates logic slightly around the new pixels added as part of unified autofill KPIs across platforms

Steps to test this PR:

NOTE - if you have an existing build with 10 or more passwords, feel free to start with Step 9 & 10 first 🙂

  1. Starting with a new install of the app, visit https://fill.dev/form/registration-username and save a new login using a generated password (triggering a fill event)
  2. Confirm these pixels DO NOT fire: m.autofill.activeuser or m.autofill.logins.stacked
  3. Perform a search in the browser
  4. Confirm these pixels fire: m.autofill.activeuser and m.autofill.logins.stacked ["count_bucket": "few"]
  5. Minimise the app and return to foreground + confirm this pixel fires: m.autofill.onboardeduser (defined as user who has stored at least 1 password within the first week)
  6. Perform another search and confirm none of the above pixels fire again
  7. Visit to https://fill.dev/form/login-simple and fill the previously saved login and again confirm none of the above pixels fire again
  8. Delete and re-install the app
  9. Save (or sync & import) 10+ logins and then perform a search
  10. Confirm this pixel fires: m.autofill.enableduser (defined as a user who is a search DAU and has at least 10 passwords saved)

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 changed the base branch from main to release/7.120.0 May 16, 2024 16:59
@amddg44 amddg44 requested a review from aataraxiaa May 16, 2024 19:27
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & LGTM @amddg44!

@amddg44 amddg44 merged commit 71b5ecb into release/7.120.0 May 17, 2024
18 checks passed
@amddg44 amddg44 deleted the anya/autofill-kpi-tweaks branch May 17, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants