Fix release branch VPN auth issues #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
May 30, 2024
| isSubscriptionEnabled: accountManager.isUserAuthenticated, | ||
| isSubscriptionEnabled: true, |
There was a problem hiding this comment.
This was the core issue, this was being used for the lifecycle of the app, so if you launched the app when you were not signed in, we didn't go through the subscription flow. Since the subscription is always enabled (this means "has launched", not "is signed in"), let's just hardcode this to true until we can remove this code completely.
diegoreymendez
approved these changes
May 30, 2024
samsymons
added a commit
that referenced
this pull request
May 31, 2024
* main: Update VPN support copy (#2894) Settings experiment disabled and new Settings rolled out to all users (#2904) Release 7.122.0-2 (#2909) PrivacyPro terms of service link (#2907) Release 7.122.0-1 (#2906) Fix release branch VPN auth issues (#2903) Disable the autofill survey (#2899) fire RMF message updated notification if we make any change to the store (#2891) Fix maestro config so it runs (#2896) Disable the autofill survey (#2899) Release 7.122.0-0 (#2898) Do not refresh collection view when we are changing the display mode (#2895) Add option to crash the app with exception from debug menu (#2897) Remove default.profraw (#2893) Guard swipe tabs scroll state (#2888)
samsymons
added a commit
that referenced
this pull request
Jun 1, 2024
# By bwaresiak (6) and others # Via Bartek Waresiak (1) and others * main: (30 commits) Update VPN support copy (#2894) Settings experiment disabled and new Settings rolled out to all users (#2904) Release 7.122.0-2 (#2909) PrivacyPro terms of service link (#2907) Release 7.122.0-1 (#2906) Fix release branch VPN auth issues (#2903) Disable the autofill survey (#2899) fire RMF message updated notification if we make any change to the store (#2891) Fix maestro config so it runs (#2896) Disable the autofill survey (#2899) Release 7.122.0-0 (#2898) Do not refresh collection view when we are changing the display mode (#2895) Add option to crash the app with exception from debug menu (#2897) Remove default.profraw (#2893) Guard swipe tabs scroll state (#2888) Add debug pixels for data cleanup (#2890) Bump rexml from 3.2.6 to 3.2.8 (#2866) Remove VPN waitlist code (#2795) Privacy Pro Follow ups (#2882) Clean up subscriptionFeature on init (#2880) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oblem.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207438971509836/f
Tech Design URL:
CC:
Description:
This PR fixes an issue with VPN authentication, where the app was keeping a value of
falseforisSubscriptionAvailableif you launched the app when signed out. This should be fixed by removing allisSubscriptionAvailablechecks soon, but for now let's fix the bug by hardcoding this to true.Steps to test this PR:
Device Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template