improve bookmarks and favorites UI tests #3019
Conversation
| @@ -432,7 +432,7 @@ | |||
| <scene sceneID="gmt-6C-Bi5"> | |||
| <objects> | |||
| <tableViewController storyboardIdentifier="BookmarkFoldersViewController" id="o1q-bZ-7v3" userLabel="Bookmark Folders" customClass="BookmarkFoldersViewController" customModule="DuckDuckGo" customModuleProvider="target" sceneMemberID="viewController"> | |||
| <tableView key="view" clipsSubviews="YES" contentMode="scaleToFill" alwaysBounceVertical="YES" dataMode="prototypes" style="insetGrouped" allowsSelectionDuringEditing="YES" rowHeight="-1" estimatedRowHeight="-1" sectionHeaderHeight="18" sectionFooterHeight="18" id="V1z-bn-1Gk"> | |||
| <tableView key="view" clipsSubviews="YES" contentMode="scaleToFill" alwaysBounceVertical="YES" keyboardDismissMode="onDrag" dataMode="prototypes" style="insetGrouped" allowsSelectionDuringEditing="YES" rowHeight="-1" estimatedRowHeight="-1" sectionHeaderHeight="18" sectionFooterHeight="18" id="V1z-bn-1Gk"> | |||
There was a problem hiding this comment.
Yep - without it, on some screens when you do
- assertVisible: "Delete"
- tapOn: "Delete"
Then maestro thinks that has worked when it hasn't and scrolling on that page doesn't bring the delete button up fair enough. The usual practice is to dismiss the keyboard on swiping a list anyway so I think it's OK.
| @@ -444,6 +438,8 @@ class BookmarksViewController: UIViewController, UITableViewDelegate { | |||
| completion(true) | |||
| } | |||
| present(alertController, animated: true) | |||
| } else if bookmark.isFolder { | |||
| delete() | |||
There was a problem hiding this comment.
This is to avoid the debug assertion, right?
Why aren't we calling the completion handler here?
There was a problem hiding this comment.
Good catch, I'll check that.
There was a problem hiding this comment.
There's a few paths that don't but I think this one should so I've added it. I had a quick look and can't really see what the implication of not calling it is. It seems that if you don't then the buttons shown on swipe don't get hidden, but since we're removing the row anyway it doesn't matter too much.
There was a problem hiding this comment.
@brindy LGTM!
I left a couple small questions just to double check, but feel free to merge if things look good to you.
* main: (24 commits) Add pixels to measure baseline for New Tab Page sections (#3024) backgrounding UI tests (#3021) improve bookmarks and favorites UI tests (#3019) [DuckPlayer] - 4. Remote Config (#3018) Updates BSK Fix issue when cancelling a download (#3030) Tentative fix for a crash and connectivity issues (#3027) autofill UI tests (#3012) scripts for running UI tests (#3000) Integrate RemoteMessaging with NewTabPage (#3017) Update to iOS 15 deployment target (#3001) Fire a pixel when removing the VPN configuration (#3014) Release 7.127.0-0 (#3020) point to BSK branch (#3016) [DuckPlayer] - 3. URL management & FE comms (#3007) Bump BSK version (#3011) New Tab Page layout and base elements (#3008) Remove Privacy Pro from device once expired account is deleted (#3009) Improvements to subscription settings (#2959) Toggle reports limiter (#3005) ...
Task/Issue URL: https://app.asana.com/0/392891325557410/1207195241923822/f
Tech Design URL:
CC: @bwaresiak
Description:
Fleshed out and tweaked bookmarks and favorites UI tests
Notes:
Steps to test this PR:
setup_ui_tests.shrun_ui_tests.sh release_tests/bookmarks.yamlrun_ui_tests.sh release_tests/bookmarks-multi.yamlrun_ui_tests.sh release_tests/favorites.yaml