VPN now recovers from WireGuard closing utun #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
samsymons
approved these changes
Aug 13, 2024
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 13, 2024
Task/Issue URL: https://app.asana.com/0/0/1208000338328853/f iOS PR: duckduckgo/iOS#3204 macOS PR: duckduckgo/macos-browser#3084 What kind of version bump will this require?: Major ## Description Adds a recovery mechanism for the tunnel so that when WireGuard throws an error on tunnel update, we restart the VPN tunnel.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 13, 2024
Task/Issue URL: https://app.asana.com/0/0/1208000338328853/f iOS: duckduckgo/iOS#3204 BSK: duckduckgo/BrowserServicesKit#931 ## Description If we detect an error while updating the tunnel configuration we now cancel the tunnel so Apple recreates the virtual interface. I believe the underlying issue is WireGuard should not "touch" the virtual interface at all, as that responsibility is owned by Apple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208000338328853/f
macOS: duckduckgo/macos-browser#3084
BSK: duckduckgo/BrowserServicesKit#931
Description
If we detect an error while updating the tunnel configuration we now cancel the tunnel so Apple recreates the virtual interface.
I believe the underlying issue is WireGuard should not "touch" the virtual interface at all, as that responsibility is owned by Apple.
Testing
Since we don't have domain exclusions in iOS it's not clear if we have the same issues in macOS as we have in iOS. I'd suggest reviewing this code and make sure the VPN works correctly in iOS.
Internal references:
Software Engineering Expectations
Technical Design Template