Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

[DuckPlayer] Experiment Fix - Update Test Variables and pixel names #3363

Merged
merged 3 commits into from
Sep 17, 2024
Merged

[DuckPlayer] Experiment Fix - Update Test Variables and pixel names #3363

merged 3 commits into from
Sep 17, 2024

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Sep 17, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1204099484721401/1208336598845809/f

Description:

  • Moves DuckPlayer launch experiment to be behind the Launch Feature flag to avoid enrolling users before time. (As it happened)
  • Renames variables and pixels to avoid collisions with the old (bogus) experiment

Steps to test this PR:

  1. Make yourself internal user
  2. Tap to Settings > All Debug Options > Reset DuckPlayer Launch Experiment. (End of list)
  3. Set a breakpoint here
  4. Run the app and watch a YouTube video
  5. Confirm app stops at the breakpoint
  6. Refresh the page, and confirm app won't stop there anymore

@afterxleep afterxleep marked this pull request as ready for review September 17, 2024 22:00
@brindy brindy self-requested a review September 17, 2024 22:09
brindy
brindy approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when setting is always ask after a clean build

@afterxleep afterxleep merged commit 741daa5 into release/7.138.0 Sep 17, 2024
31 checks passed
@afterxleep afterxleep deleted the daniel/duckplayer.experiment.fix branch September 17, 2024 22:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afterxleep @brindy