Update to subscription cookie #3512
Merged
+55
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
samsymons
approved these changes
Nov 1, 2024
miasma13
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Nov 1, 2024
<!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1108686900785972/1208264562025859/f iOS PR: duckduckgo/iOS#3512 macOS PR: duckduckgo/macos-browser#3489 What kind of version bump will this require?: Patch **Description**: Update to how the subscription cookie operates: - constraint the cookie to `subscriptions.duckduckgo.com` - on sign out do not fully remove the cookie - just clear the value - gate the feature behind the `setAccessTokenCookieForSubscriptionDomains` privacy config feature flag **Steps to test this PR**: See client PRs <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
samsymons
added a commit
that referenced
this pull request
Nov 1, 2024
…the-os # By Daniel Bernal (6) and others # Via Daniel Bernal (4) and Michal Smaga (1) * main: Update build number Update build number Bump rexml from 3.3.8 to 3.3.9 (#3495) Release 7.142.1-1 (#3525) Add a debouncer to NavBars animator (#3519) Release 7.143.0-1 (#3516) Update to subscription cookie (#3512) Bug Fix: Phishing Detection Dataset Discrepancies (#3469) Duckplayer New Tab + Refactor (#3491) Blind attempt to fix Omnibar-related crash (#3514) Fix VPN server info metadata (#3501) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Nov 4, 2024
# By Daniel Bernal (6) and others # Via Daniel Bernal (3) and others * main: (21 commits) Validate VPN errors before re-throwing them (#3513) Allowing users to delete suggestions on macOS (#3465) Update build number Update build number Bump rexml from 3.3.8 to 3.3.9 (#3495) Release 7.142.1-1 (#3525) Add a debouncer to NavBars animator (#3519) Release 7.143.0-1 (#3516) Update to subscription cookie (#3512) Bug Fix: Phishing Detection Dataset Discrepancies (#3469) Duckplayer New Tab + Refactor (#3491) Blind attempt to fix Omnibar-related crash (#3514) Fix VPN server info metadata (#3501) Set version_check_wait_retry_limit to 1 (#3511) BSK changes for macOS release note screen update (#3466) Onboarding Add to Dock Promo view (#3505) Update BSK with autofill 15.1.0 (#3507) Update tests to use new tagline (#3439) adding impression pixels for duckplayer in landscape mode (#3493) Update autoconsent to v10.17.0 (#3504) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Nov 5, 2024
# By Daniel Bernal (7) and others # Via Daniel Bernal (3) and others * main: (29 commits) Send pixel on sync secure storage failure (#3542) Onboarding Add to Dock Refactor for Intro scenario (#3538) Update C-S-S to 6.29.0 (#3541) Change save password Never for Site button to Not Now (#3471) Release 7.144.0-1 (#3540) UserDefaults misbehavior monitoring (#3510) Send pixel on sync secure storage read failure (#3530) Remove NewTabPage retain cycles (#3532) Update release notes (#3529) Release 7.144.0-0 (#3528) Add Privacy Config feature to control ad attribution reporting (#3506) Validate VPN errors before re-throwing them (#3513) Allowing users to delete suggestions on macOS (#3465) Update build number Update build number Bump rexml from 3.3.8 to 3.3.9 (#3495) Release 7.142.1-1 (#3525) Add a debouncer to NavBars animator (#3519) Release 7.143.0-1 (#3516) Update to subscription cookie (#3512) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1108686900785972/1208264562025859/f
Description:
Initial PR -> #3488
Update to how the subscription cookie operates:
subscriptions.duckduckgo.comsetAccessTokenCookieForSubscriptionDomainsprivacy config feature flagSteps to test this PR:
To inspect website cookies use "Cookies" in the debug menu. Please mind that cookies may appear empty with no WebView being instantiated (no tabs), ensure there is at least tab with webpage open (unless required not to).
To test purchase use the real device and test the Alpha target.
4.Test that when feature flag is enabled after signing out of the subscription the cookie is updated with empty value
Internal references:
Software Engineering Expectations
Technical Design Template