Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not refresh cookie on config update #3613

Merged

Conversation

miasma13
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414709148257752/1208829922317861/f
CC: @bwaresiak

Description:

  • Do not refresh the cookie on config change when flag was detected enabled
  • Guard the code not to execute while the app is still launching / has not completed launching
  • Make the task for interaction with subscriptionCookieManager use main actor

Steps to test this PR:
Test enabling and disabling the setAccessTokenCookieForSubscriptionDomains feature flag.

Definition of Done (Internal Only):


Internal references:

Software Engineering Expectations
Technical Design Template

@miasma13 miasma13 requested a review from samsymons November 23, 2024 15:56
miasma13 added a commit that referenced this pull request Nov 23, 2024
Task/Issue URL:
https://app.asana.com/0/414709148257752/1208829922317861/f

**Description**:
Applying hotfix changes from #3613

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
@miasma13 miasma13 merged commit df2abf7 into hotfix/7.145.1 Nov 23, 2024
9 of 10 checks passed
@miasma13 miasma13 deleted the michal/do-not-refresh-cookie-on-config-update branch November 23, 2024 16:34
samsymons added a commit that referenced this pull request Nov 24, 2024
# By Michal Smaga (1) and Sam Symons (1)
# Via GitHub
* hotfix/7.145.1:
  Release 7.145.1-0 (#3615)
  Do not refresh cookie on config update (#3613)

# Conflicts:
#	Configuration/Version.xcconfig
#	DuckDuckGo/Settings.bundle/Root.plist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants