Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CookieDebugViewController segue #3631

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Nov 27, 2024

Task/Issue URL: https://app.asana.com/0/1206226850447395/1208841739510098/f
Tech Design URL:
CC:

Description:

Segue requires init(coder:). This uses custom initialization to inject expected params.

Steps to test this PR:

  1. Open Settings -> Debug -> Cookies

Definition of Done (Internal Only):


Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 requested a review from brindy November 27, 2024 11:56
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for jumping on it.

@dus7 dus7 merged commit b280df0 into release/7.147.0 Nov 27, 2024
14 of 15 checks passed
@dus7 dus7 deleted the mariusz/fix-cookie-debug branch November 27, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants