This repository was archived by the owner on Feb 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 430
Crash report cohort ID support for iOS #3692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove app-level CRCID user setting, and prepare for clearing CRCID owned by BSK (BSK changes still to come).
Oops, clearing CRCID needs to be done through CrashCollection, which now supports this properly.
Support for sending error pixels when crash report submission fails or a CRCID is not returned by the server when expected.
samsymons
reviewed
Dec 14, 2024
samsymons
reviewed
Dec 19, 2024
# By Michal Smaga (10) and others # Via Michal Smaga (4) and others * main: (66 commits) DuckPlayer: Don’t open new tabs or DuckPlayer at launch when in alwaysAsk mode (#3738) Fix BrowsingMenu layout (#3712) Remove ESLint config files (#3739) Release 7.150.0-1 (#3742) An additional protective in case users try to access the passwords list via the extension, before launching the app Ensure migration has occurred before accessing vault Populate credential store if user has enabled before launching app Update to target main app Ensure migration has occurred before accessing vault Release 7.149.1-0 (#3740) An additional protective in case users try to access the passwords list via the extension, before launching the app Ensure migration has occurred before accessing vault Populate credential store if user has enabled before launching app Update to target main app Ensure migration has occurred before accessing vault Bugfix: Fix Youtube Internal links when 'Watching on Youtube' from Duck Player (#3733) point to BSK branch (#3732) Remove duck.ai 10min timer (#3731) Release 7.150.0-0 (#3729) Update autoconsent to v12.3.0 (#3728) ... # Conflicts: # Core/PixelEvent.swift # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
approved these changes
Dec 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1208592102886666/1208759541597499/f
Tech Design URL: https://app.asana.com/0/1208592102886666/1208660326715650/f
Description:
DO NOT MERGE - this is a draft for input, not ready to go live yet.
iOS client support for CRCID send/receive (primarily supported in BSK, with changes under review in BSK #1116). This is pretty straightforward, just conforming to CrashCollection’s new init signature, and clearing CRCIDs when the user opts out of crash reporting. BSK handles everything else.
Steps to test this PR:
Note: Must be tested on a physical device, as the simulator does not produce crash logs (and thus doesn’t find and upload them either).
To cause and report a crash:
To test clearing of the crcid when opting out:
Definition of Done (Internal Only):
Copy Testing: N/A
’
rather than’
Orientation Testing: N/A
Device Testing:
OS Testing:
Theme Testing: N/A
—
Internal references:
Software Engineering Expectations
Technical Design Template