Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable System credential extension on release + translations #3706

Merged

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Dec 10, 2024

Task/Issue URL: https://app.asana.com/0/1201645688934642/1207540610577903/f
Tech Design URL:
CC:

Description:
Enables the app to be a system level credential provider on the main app target + translations and final ship review feedback

Steps to test this PR:

  1. Continuing with the Alpha app target, go to Safari on iOS 18 test that the tooltip ‘Autofill’ -> ‘Passwords’ works, allowing text to be selected to fill web form fields
  2. Access the list of passwords via the extension and confirm tapping on the disclosure indicator takes you to the details screen
  3. Ensure selecting a password from this list still works as before
  4. Change device language and confirm the extension screens are translated
  5. In Xcode, under the DuckDuckGo target > Signing & Capabilities, validate that the Autofill Credential Provider capability is present on all variants (debug, alpha debug etc)

<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
—>

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link

github-actions bot commented Dec 10, 2024

Fails
🚫 DesignResourcesKit: No new colors should be added to this app.
Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 55f78d2

@amddg44 amddg44 requested a review from aataraxiaa December 10, 2024 12:09
@@ -118,67 +143,9 @@ class CredentialProviderListItemTableViewCell: UITableViewCell {

separatorInset = UIEdgeInsets(top: 0, left: contentView.layoutMargins.left + textStackView.frame.origin.x, bottom: 0, right: 0)
}


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve moved this image code out to FaviconHelper as it was also needed for the password details screen

@amddg44 amddg44 changed the base branch from main to release/7.149.0 December 10, 2024 13:07
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM @amddg44 ! 🚀

@amddg44 amddg44 merged commit 352d7bb into release/7.149.0 Dec 10, 2024
17 of 18 checks passed
@amddg44 amddg44 deleted the anya/system-credential-extension-release-update branch December 10, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants