-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable System credential extension on release + translations #3706
Enable System credential extension on release + translations #3706
Conversation
…etails screen from list of credentials
…ompt to navbar on list of passwords screen
|
@@ -118,67 +143,9 @@ class CredentialProviderListItemTableViewCell: UITableViewCell { | |||
|
|||
separatorInset = UIEdgeInsets(top: 0, left: contentView.layoutMargins.left + textStackView.frame.origin.x, bottom: 0, right: 0) | |||
} | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve moved this image code out to FaviconHelper
as it was also needed for the password details screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM @amddg44 ! 🚀
Task/Issue URL: https://app.asana.com/0/1201645688934642/1207540610577903/f
Tech Design URL:
CC:
Description:
Enables the app to be a system level credential provider on the main app target + translations and final ship review feedback
Steps to test this PR:
<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.
Using a simulator where a physical device is unavailable is acceptable.
—>
Definition of Done (Internal Only):
Copy Testing:
’
rather than’
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template