Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AI Chat address bar pixel #3720

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix AI Chat address bar pixel #3720

merged 1 commit into from
Dec 12, 2024

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Dec 12, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414235014887631/1208965876736143/f

Description:
Fire AI Chat address bar pixel
Fixes share button pixel

Steps to test this PR:
Set yourself as internal user

  1. Do a search, tap on AI Chat address bar, check if we send the m_aichat_addressbar_icon pixel
  2. Open a webpage, tap on share on the address bar, check if we send the m_addressbar_share pixel

@Bunn Bunn requested a review from brindy December 12, 2024 12:34
brindy
brindy approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Bunn Bunn merged commit d70d5cd into release/7.149.0 Dec 12, 2024
18 checks passed
@Bunn Bunn deleted the bunn/aichat/pixel-fix branch December 12, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bunn @brindy