Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set state when user cancelled the purchase #3725

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

miasma13
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414709148257752/1208967366086507/f

Description:
Do not trigger 'm_privacy-pro_app_subscription-purchase_failure_other' pixel when cancelling the purchase.

Steps to test this PR:
(Since steps do not involve purchase it can be verified on simulator)

  1. Ensure no Privacy Pro is on the device
  2. Open Settings -> "Get Privacy Pro"
  3. Select one of the two options (monthly or annual)
  4. Select "Subscribe" to confirm ToS
  5. When iOS shows alert prompting to confirm purchase and/or to sign into Apple ID account tap "Cancel" to stop the purchase flow.
  6. Ensure that the cancel action is not triggering m_privacy-pro_app_subscription-purchase_failure_other pixel to be fired

Definition of Done (Internal Only):


Internal references:

Software Engineering Expectations
Technical Design Template

@miasma13 miasma13 requested a review from afterxleep December 12, 2024 15:59
Copy link
Collaborator

@afterxleep afterxleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miasma13 miasma13 merged commit e061619 into release/7.149.0 Dec 13, 2024
16 checks passed
@miasma13 miasma13 deleted the michal/fix-cancelled-is-not-an-error branch December 13, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants