Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point to BSK branch #3732

Merged
merged 4 commits into from
Dec 17, 2024
Merged

point to BSK branch #3732

merged 4 commits into from
Dec 17, 2024

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented Dec 17, 2024

Task/Issue URL: https://app.asana.com/0/1204186595873227/1208964427775425/f

Description: Update BSK dependency

Steps to test this PR:

  1. Check tests pass

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio marked this pull request as ready for review December 17, 2024 09:02
SabrinaTardio added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Dec 17, 2024
Task/Issue URL:
https://app.asana.com/0/1204186595873227/1208964427775425/f
iOS PR:  duckduckgo/iOS#3732
macOS PR: duckduckgo/macos-browser#3670
What kind of version bump will this require?: Minor
@SabrinaTardio SabrinaTardio merged commit c55b610 into main Dec 17, 2024
13 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/change-experiment-api branch December 17, 2024 14:25
samsymons added a commit that referenced this pull request Dec 19, 2024
# By Michal Smaga (10) and others
# Via Michal Smaga (4) and others
* main: (66 commits)
  DuckPlayer: Don’t open new tabs or DuckPlayer at launch when in alwaysAsk mode (#3738)
  Fix BrowsingMenu layout (#3712)
  Remove ESLint config files (#3739)
  Release 7.150.0-1 (#3742)
  An additional protective in case users try to access the passwords list via the extension, before launching the app
  Ensure migration has occurred before accessing vault
  Populate credential store if user has enabled before launching app
  Update to target main app
  Ensure migration has occurred before accessing vault
  Release 7.149.1-0 (#3740)
  An additional protective in case users try to access the passwords list via the extension, before launching the app
  Ensure migration has occurred before accessing vault
  Populate credential store if user has enabled before launching app
  Update to target main app
  Ensure migration has occurred before accessing vault
  Bugfix: Fix Youtube Internal links when 'Watching on Youtube' from Duck Player (#3733)
  point to BSK branch (#3732)
  Remove duck.ai 10min timer (#3731)
  Release 7.150.0-0 (#3729)
  Update autoconsent to v12.3.0 (#3728)
  ...

# Conflicts:
#	Core/PixelEvent.swift
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants