Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/7.149.1 #3736

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Hotfix/7.149.1 #3736

merged 6 commits into from
Dec 18, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Dec 18, 2024

Task/Issue URL: https://app.asana.com/0/1203822806345703/1209004527215789/f
Tech Design URL:
CC:

Description:
Ensure enabling credential provider extension before the app has had a chance to migrate the vault does not cause an empty vault to be created

Steps to test this PR:

  1. Testing on device, if you have already migrated follow steps 2 - 4 otherwise skip to step 5
  2. Install the build from https://app.asana.com/0/1203822806345703/1209004527215789/f
  3. Turn DDG off as a system credential provider
  4. Go to the Debug screen > Keychain Items and tap the button at the top right to remove all v4 migrated data
  5. Downgrade to an older version of the app via TestFlight
  6. Save some passwords for autofill.me
  7. Download the build from this branch https://github.com/duckduckgo/iOS/actions/runs/12396783108
  8. Toggle DuckDuckGo on as an credential provider. Tap “Done” to dismiss the screen
  9. Launch the app, visit the Passwords screen and confirm your passwords are present
  10. Go back to Safari and visit autofill.me. Confirm you are prompted with saved passwords / can view passwords via the extension

<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
—>

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 requested review from graeme and aataraxiaa December 18, 2024 15:04
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on MM, the issue is still present with the latest changes.

…st via the extension, before launching the app
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @amddg44, fixes the issue.

@amddg44 amddg44 merged commit cb89fea into main Dec 18, 2024
@amddg44 amddg44 deleted the hotfix/7.149.1 branch December 18, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants